Skip to content

rename from date format to format date#9902

Merged
sophiajt merged 2 commits intonushell:mainfrom
WindSoilder:format_datetime
Aug 3, 2023
Merged

rename from date format to format date#9902
sophiajt merged 2 commits intonushell:mainfrom
WindSoilder:format_datetime

Conversation

@WindSoilder
Copy link
Copy Markdown
Contributor

@WindSoilder WindSoilder commented Aug 2, 2023

Description

Closes: #9891
I also think it's good to keep command name consistency.

And moving date format to deprecated.

User-Facing Changes

Running date format will lead to deprecate message:

 "2021-10-22 20:00:12 +01:00" | date format
Error: nu::shell::deprecated_command

  × Deprecated command date format
   ╭─[entry #28:1:1]
 1  "2021-10-22 20:00:12 +01:00" | date format
   ·                                ─────┬─────
   ·                                     ╰── 'date format' is deprecated. Please use 'format date' instead.
   ╰────

@WindSoilder WindSoilder added the notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes label Aug 2, 2023
@sophiajt sophiajt merged commit 14bf25d into nushell:main Aug 3, 2023
IanManske pushed a commit to IanManske/nushell that referenced this pull request Aug 3, 2023
# Description
Closes: nushell#9891
I also think it's good to keep command name consistency.

And moving `date format` to deprecated.

# User-Facing Changes
Running `date format` will lead to deprecate message:
```nushell
❯ "2021-10-22 20:00:12 +01:00" | date format
Error: nu::shell::deprecated_command

  × Deprecated command date format
   ╭─[entry nushell#28:1:1]
 1 │ "2021-10-22 20:00:12 +01:00" | date format
   ·                                ─────┬─────
   ·                                     ╰── 'date format' is deprecated. Please use 'format date' instead.
   ╰────
```
amtoine added a commit to amtoine/scripts that referenced this pull request Aug 4, 2023
@WindSoilder WindSoilder deleted the format_datetime branch October 26, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nitpick: date format, but format duration?

2 participants