Skip to content

update items signature to allow any output#9896

Merged
fdncred merged 2 commits intonushell:mainfrom
fdncred:update_items_signature_with_any
Aug 2, 2023
Merged

update items signature to allow any output#9896
fdncred merged 2 commits intonushell:mainfrom
fdncred:update_items_signature_with_any

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Aug 2, 2023

Description

This PR updates the items command to allow any output. items takes a closure so theoretically, any value type of output could be valid.

Before

{a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
Error: nu::parser::input_type_mismatch

  × Command does not support list<string> input.
   ╭─[entry #2:1:1]
 1  {a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
   ·                                                   ────┬────
   ·                                                       ╰── command doesn't support list<string> input
   ╰────

After

 {a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
╭───┬─────────┬─────────┬─────────╮
 # │ column0 │ column1 │ column2 │
├───┼─────────┼─────────┼─────────┤
 0  key      a        b       
 1  value          1        2 
╰───┴─────────┴─────────┴─────────╯

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred added the A:type-system Problems or features related to nushell's type system label Aug 2, 2023
@fdncred fdncred merged commit dd86f14 into nushell:main Aug 2, 2023
@fdncred fdncred deleted the update_items_signature_with_any branch August 2, 2023 13:42
IanManske pushed a commit to IanManske/nushell that referenced this pull request Aug 3, 2023
# Description

This PR updates the `items` command to allow `any` output. items takes a
closure so theoretically, any value type of output could be valid.

### Before
```nushell
{a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
Error: nu::parser::input_type_mismatch

  × Command does not support list<string> input.
   ╭─[entry nushell#2:1:1]
 1 │ {a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
   ·                                                   ────┬────
   ·                                                       ╰── command doesn't support list<string> input
   ╰────
```

### After
```nushell
❯ {a: 1 b: 2} | items {|k,v| {key: $k value: $v}} | transpose
╭───┬─────────┬─────────┬─────────╮
│ # │ column0 │ column1 │ column2 │
├───┼─────────┼─────────┼─────────┤
│ 0 │ key     │ a       │ b       │
│ 1 │ value   │       1 │       2 │
╰───┴─────────┴─────────┴─────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:type-system Problems or features related to nushell's type system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant