Skip to content

add a comment note to the PR template about linking issues#9392

Merged
fdncred merged 2 commits intonushell:mainfrom
amtoine:pr-template/linking-issues
Jun 10, 2023
Merged

add a comment note to the PR template about linking issues#9392
fdncred merged 2 commits intonushell:mainfrom
amtoine:pr-template/linking-issues

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Jun 9, 2023

i see very often contributors mentionning an issue that their PR is supposed to solve without using the proper linking keywords of GitHub 🤔

in this PR, i've added a little comment to the top of the PR template to hopefully explain how to achieve this automatically without requiring maintainers to link PRs manually 😌

@amtoine amtoine mentioned this pull request Jun 9, 2023
fdncred pushed a commit that referenced this pull request Jun 9, 2023
related to
-
bdb09a9
- [this
job](https://github.com/nushell/nushell/actions/runs/5224369668/jobs/9432486180?pr=9392)
from #9392
- [this
job](https://github.com/nushell/nushell/actions/runs/5222835000/jobs/9428854834?pr=9391)
from #9391

# Description
this PR tries to fix the typo reported in these very recent PRs
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Jun 10, 2023

📯 📯 little annoucement

the Typos CI job is failing in this PR.
this has been fixed in #9393 👍

in this PR, you can either

  • merge the new main branch into the PR branch to explicitely have a ✔️ here
  • wait for the PR to land and the CI should be ✔️ once landed on the main branch 😌

…issues

This should solve the typos issue in the CI in nushell#9392 with the new
correct main.
@fdncred fdncred merged commit e605d80 into nushell:main Jun 10, 2023
@amtoine amtoine deleted the pr-template/linking-issues branch June 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants