i'm just missing the parameters and flags part of show-command 🤔
fixed in 2e75122

i'm a bit off with some newlines and minor format details, but i think it's ready for review 😌

if any reviewer find something off, i'll change it, that should only be small tweaks 😉

and after a quick test, it looks around as slow as before... (:laughing:)

@fdncred

i ping you for review if you want to have a look before merging 😉

i think it looks ok and should not introduce too many differences with the previous version.
and that would open the important door of testing the std help module 😋

@amtoine What do I have to do to test it? I've tried use std help then std help modules but that doesn't work any longer.

@amtoine What do I have to do to test it? I've tried use std help then std help modules but that doesn't work any longer.

i think jakub broke the prelude in this recent PRs 👀
working on it... ♻️

you'd have to run

use std
std help modules

or

use std help
std help

Thanks, that helped. Here's my feedback.

• std help = good to go
• std help help = good to go (except we should proably remove/change the help str lpad since that's deprecated)
• std help str lpad = not a fan of the "This command:" section. I'm not sure users care about that information.
  maybe a different format would be more acceptible, so it doesn't take 7 lines? perhaps this?

[] scope [x] builtin [x] subcommand [] plugin [] custom [] keyword

• std help aliases = good to go
• std help commands = good to go. signatures are different but i'm not sure that matters that much
• std help -f arg = seems like we need to work on usage versus extra_usage. I really don't like seeing so much information in the usage but i don't think there's a way to make extra_usage in custom commands yet.
• std help externs = good to go
• std help externs -f update - coloring is broken on the last line of usage. i wonder if that's a nushell bug?
• std help modules = good to go
• std help operators = good to go
• std help operators -f math = good to go
• std help dirs = i like the old format/look better (highlighted aliases, exported commands don't have command in parens).
  just speculating i wonder if it would be more helpful to show something like?
  [[exported_command exported_alias]; [add enter] [drop dexit] [goto g] [next n] [prev p] [show shells]]
• std help xml (or any other std cmd)
  not sure about the "Help pages from external command xml"
  • it's not external
  • it's in italic and looks odd

Did i miss anything?

@fdncred
i'll check that more closely tomorrow 😌 😉

one question though: the bad points above have been created with this PR or were there before?
if the latter, i'd rather fix them once we write tests for the std help commands, if that's ok with you 😊

the bad points above have been created with this PR

This PR. I only checked this PR compared to before this PR.

This PR. I only checked this PR compared to before this PR.

perfect 👌

i'm having a look at the points above right now 😏

mm i'm a bit confused, all the points you list above look they were there before this PR 😕

i even feel they are tracked in the bounty for the most part 😮

looks to me we can merge this and address these one at a time next 😌
but yeah i still agree these are issues to be addressed 👍

I think the problem is that PRs keep getting submitted that don't fix the issues so I end up reviewing PRs over and over again and each PR has the same issues. Maybe going forward we should fix the issues before fixing internal things like build vs print. I really don't want to look at several issues and decide whether I've asked for a fix for this particular thing or not before commenting on it. It makes it really difficult to review PRs that way.

that's true 👍

but at the same time, this PR was meant to be a step forward to allow us write tests for the std help commands!
until now we've only been eye-balling what does not work.
with this PR, we'll hopefully be able to write Nushell tests for these, as it's done in the Rust side

i'll continue working on stabilizing the std help commands... 😌