use let-else syntax where possible#8886
Merged
sholderbach merged 2 commits intonushell:mainfrom Apr 14, 2023
1Kinoti:let-else
Merged
use let-else syntax where possible#8886sholderbach merged 2 commits intonushell:mainfrom 1Kinoti:let-else
let-else syntax where possible#8886sholderbach merged 2 commits intonushell:mainfrom
1Kinoti:let-else
Conversation
Contributor
|
nice. i like how it starts to minimize the rightward drift of rust. I think |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8886 +/- ##
==========================================
+ Coverage 68.12% 68.49% +0.36%
==========================================
Files 635 635
Lines 101520 101512 -8
==========================================
+ Hits 69163 69530 +367
+ Misses 32357 31982 -375
|
sholderbach
approved these changes
Apr 14, 2023
Member
sholderbach
left a comment
There was a problem hiding this comment.
Thanks! Makes it more readable (if you are somewhat up to date with Rust)
bobhy
pushed a commit
to bobhy/nushell
that referenced
this pull request
Apr 15, 2023
# Description this pr changes some `if-let`s to `let-else`s # User-Facing Changes none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this pr changes some
if-lets tolet-elsesUser-Facing Changes
none