Fix span of multibyte short flags#8866
Merged
sholderbach merged 2 commits intonushell:mainfrom Apr 14, 2023
Merged
Conversation
Follow up to nushell#8849 Work for nushell#8821
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8866 +/- ##
==========================================
- Coverage 68.50% 68.49% -0.01%
==========================================
Files 635 635
Lines 101520 101520
==========================================
- Hits 69545 69536 -9
- Misses 31975 31984 +9
|
sholderbach
added a commit
to MariaSolOs/nushell
that referenced
this pull request
Apr 14, 2023
- Include the span fixes from nushell#8866 - Include the `break;` back in - Remove unnecessary clone
bobhy
pushed a commit
to bobhy/nushell
that referenced
this pull request
Apr 15, 2023
# Description Follow up to nushell#8849 Work for nushell#8821 Should unblock work on nushell#8808 Missing is a restriction to printables or identifiers according to [UAX31](https://www.unicode.org/reports/tr31/) # User-Facing Changes Non ASCII characters should be allowed in shortflags. # Tests + Formatting Want to add some tests for the error reporting cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #8849
Work for #8821
Should unblock work on #8808
Missing is a restriction to printables or identifiers according to UAX31
User-Facing Changes
Non ASCII characters should be allowed in shortflags.
Tests + Formatting
Want to add some tests for the error reporting cases