Skip to content

Remove old alias implementation#8797

Merged
kubouch merged 4 commits intonushell:mainfrom
kubouch:remove-old-alias
Apr 7, 2023
Merged

Remove old alias implementation#8797
kubouch merged 4 commits intonushell:mainfrom
kubouch:remove-old-alias

Conversation

@kubouch
Copy link
Copy Markdown
Contributor

@kubouch kubouch commented Apr 7, 2023

Description

Removes the old alias implementation.

The only remaining issues with the new alias implementation is missing completions with external completers and no support for aliasing a call with env shorthand (alias foo = FOO=bar run-something). Also some presentation issues, like which and wrong usage. I think these are not deal breakers and we can go ahead with the removal.

User-Facing Changes

old-alias is no longer available.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass
  • cargo run -- crates/nu-utils/standard_library/tests.nu to run the tests for the standard library

Note
from nushell you can also use the toolkit as follows

use toolkit.nu  # or use an `env_change` hook to activate it automatically
toolkit check pr

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@kubouch kubouch added the notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes label Apr 7, 2023
@kubouch kubouch merged commit 1b677f1 into nushell:main Apr 7, 2023
@kubouch kubouch deleted the remove-old-alias branch April 7, 2023 18:09
amtoine added a commit to amtoine/nushell that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant