Skip to content

stdlib: add assert skip command to skip test case#8748

Merged
fdncred merged 2 commits intonushell:mainfrom
presidento:std-assert-skip
Apr 6, 2023
Merged

stdlib: add assert skip command to skip test case#8748
fdncred merged 2 commits intonushell:mainfrom
presidento:std-assert-skip

Conversation

@presidento
Copy link
Copy Markdown
Contributor

Add assert skip command to skip test case.

image

@fdncred fdncred added the A:std-library Defining and improving the standard library written in Nu label Apr 5, 2023
Copy link
Copy Markdown
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks great really 😮 👍

@fdncred fdncred marked this pull request as draft April 6, 2023 11:30
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Apr 6, 2023

make draft until @amtoine can look at the latest changes

Copy link
Copy Markdown
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the last tweak, that's great 👌

@amtoine
Copy link
Copy Markdown
Member

amtoine commented Apr 6, 2023

make draft until @amtoine can look at the latest changes

all good @fdncred 😌

@presidento presidento marked this pull request as ready for review April 6, 2023 16:46
@fdncred fdncred merged commit 74283c3 into nushell:main Apr 6, 2023
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Apr 6, 2023

Thanks

amtoine added a commit to amtoine/nushell that referenced this pull request Apr 7, 2023
This adds the `help` commands from nushell#8505 and the `assert skip`
from nushell#8748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants