Remove CI coverage until we can figure out why it's broken#8677
Merged
sophiajt merged 1 commit intonushell:mainfrom Mar 30, 2023
Merged
Remove CI coverage until we can figure out why it's broken#8677sophiajt merged 1 commit intonushell:mainfrom
sophiajt merged 1 commit intonushell:mainfrom
Conversation
Merged
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Apr 12, 2023
This reverts commit 0e496f9. (nushell#8677)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The coverage testing on CI has been broken for at least a week. It looks like we might have to do some work, but for now, disabling it so we don't give bad stability info to contributors.
User-Facing Changes
(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passcargo run -- crates/nu-utils/standard_library/tests.nuto run the tests for the standard libraryAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.