Merged
Conversation
Contributor
Author
|
I know it's getting close but I'd like to include this in the 0.78 release; I think it goes well with the other changes to cell paths. |
Contributor
|
We still have 7 days. I'd vote to land it too. |
Contributor
Author
Whoops, I lost track of time; thought it was less for some reason. Thanks! |
Member
So we can skip marking this as a breaking change? Thanks should reduce type confusion! |
Contributor
Author
|
Yeah, it could break scripts in theory but I doubt anyone was depending on this behaviour. |
Contributor
Author
|
For context, this came up on Discord; a user was having trouble with web APIs that sometimes return an empty list. |
WindSoilder
pushed a commit
to WindSoilder/nushell
that referenced
this pull request
Mar 29, 2023
This PR fixes `select` when given an empty list; it used to return `null` when given an empty list. I also cleaned up other `select` tests while I was in the area. ### Before: ``` > [] | select a | to nuon null ``` ### After: ``` > [] | select a | to nuon [] ``` It looks like the previous behaviour was accidentally introduced by [this PR](nushell#7639).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
selectwhen given an empty list; it used to returnnullwhen given an empty list. I also cleaned up otherselecttests while I was in the area.Before:
After:
It looks like the previous behaviour was accidentally introduced by this PR.