stdlib: Add back recursive lookup for tests#8632
Merged
fdncred merged 1 commit intonushell:mainfrom Mar 28, 2023
Merged
Conversation
amtoine
reviewed
Mar 27, 2023
Member
amtoine
left a comment
There was a problem hiding this comment.
thanks a lot, i might have been a bit too quick on this during the refactoring 😉
only a very minor thing and i'll approve for sure 🥳
09ae6a6 to
2f4cf3b
Compare
amtoine
reviewed
Mar 28, 2023
Member
amtoine
left a comment
There was a problem hiding this comment.
the code looks good to me thanks for the small change 😌
i do not approve, the time i test this locally 😉
Member
|
i have a strange error on machine... >_ cargo run -- crates/nu-utils/standard_library/tests.nu
Error: nu::parser::parse_mismatch
× Parse mismatch during operation.
╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/test_asserts.nu:13:1]
13 │ assert error { assert equal 1 "foo" }
14 │ assert error { assert equal (1 + 2) 4) }
· ─┬
· ╰── expected number-like value (int, float, date, etc)
15 │ }
╰────does this |
Contributor
|
The problem is that these two lines need to look like this and For some reason they were just 4) and 3) |
amtoine
approved these changes
Mar 28, 2023
Member
amtoine
left a comment
There was a problem hiding this comment.
ooookey, found it thanks to @fdncred 👌
i've introduced a very bad set of tests in #8150 and we see them in action here...
we need to apply the following patch
diff --git a/crates/nu-utils/standard_library/test_asserts.nu b/crates/nu-utils/standard_library/test_asserts.nu
index ddb21049f..1c1dc30c8 100644
--- a/crates/nu-utils/standard_library/test_asserts.nu
+++ b/crates/nu-utils/standard_library/test_asserts.nu
@@ -11,13 +11,13 @@ export def test_assert_equal [] {
assert equal (1 + 2) 3
assert equal (0.1 + 0.2 | into string | into decimal) 0.3 # 0.30000000000000004 == 0.3
assert error { assert equal 1 "foo" }
- assert error { assert equal (1 + 2) 4) }
+ assert error { assert equal (1 + 2) 4 }
}
export def test_assert_not_equal [] {
assert not equal (1 + 2) 4
assert not equal 1 "foo"
- assert not equal (1 + 2) 3)
+ assert not equal (1 + 2) "3"
assert error { assert not equal 1 1 }
}and the tests pass 👍
i think we can land this PR and i'll patch the tests at the same time 😌
Contributor
|
ok, thanks. |
fdncred
pushed a commit
that referenced
this pull request
Mar 28, 2023
Related to #8150, #8635 and #8632. # Description i've introduced a bad set of tests for the `assert equal` command in #8150... they should not compare `1 + 2` and `4)` or `3)` but the ints. in this PR, i remove this spurious parentheses that were not planned at all 😬 👀 # User-Facing Changes ``` $nothing ``` # Tests + Formatting ``` >_ nu crates/nu-utils/standard_library/tests.nu INF|2023-03-28T20:18:13.022|Running tests in test_asserts INF|2023-03-28T20:18:13.173|Running tests in test_dirs INF|2023-03-28T20:18:13.247|Running tests in test_logger INF|2023-03-28T20:18:13.473|Running tests in test_std ``` # After Submitting ``` $nothing ```
WindSoilder
pushed a commit
to WindSoilder/nushell
that referenced
this pull request
Mar 29, 2023
@amtoine during the refactor the test runner lost the ability for looking up for test modules in subdirectories. I just added it back now.
WindSoilder
pushed a commit
to WindSoilder/nushell
that referenced
this pull request
Mar 29, 2023
Related to nushell#8150, nushell#8635 and nushell#8632. # Description i've introduced a bad set of tests for the `assert equal` command in nushell#8150... they should not compare `1 + 2` and `4)` or `3)` but the ints. in this PR, i remove this spurious parentheses that were not planned at all 😬 👀 # User-Facing Changes ``` $nothing ``` # Tests + Formatting ``` >_ nu crates/nu-utils/standard_library/tests.nu INF|2023-03-28T20:18:13.022|Running tests in test_asserts INF|2023-03-28T20:18:13.173|Running tests in test_dirs INF|2023-03-28T20:18:13.247|Running tests in test_logger INF|2023-03-28T20:18:13.473|Running tests in test_std ``` # After Submitting ``` $nothing ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amtoine during the refactor the test runner lost the ability for looking up for test modules in subdirectories. I just added it back now.