Revert "Throw out error if external command in subexpression is failed to run (#8204)"#8475
Merged
sophiajt merged 1 commit intonushell:mainfrom Mar 16, 2023
Merged
Conversation
…d to run (nushell#8204)" This reverts commit dec0a25.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8475 +/- ##
==========================================
- Coverage 68.05% 68.05% -0.01%
==========================================
Files 621 621
Lines 99938 99866 -72
==========================================
- Hits 68015 67960 -55
+ Misses 31923 31906 -17
|
|
Does this fix #8467 ? Does |
yes (no delay or graphical issues for me) |
|
@jntrnr could a hotfix be released? also, maybe tests should be added so that this situation doesn't happen again? |
sophiajt
pushed a commit
that referenced
this pull request
Mar 17, 2023
…d to run (#8204)" (#8475) This reverts commit dec0a25. It breaks programs like `fzf` # Description Fixes: #8472 Fixes: #8313 Reopen: #7690 # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dec0a25.
It breaks programs like
fzfDescription
Fixes: #8472
Fixes: #8313
Reopen: #7690
User-Facing Changes
(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.