The first casualty. /cc @jntrnr

At the end of this script it calls several custom commands. I think they should all still print output but only the last one does. This is how the end of the script looks

print_run 0 16 # The first 16 colours are spread over the whole spectrum
print ""             # Single line
print_blocks 16 123 6 6 3 # 6x6x6 colour cube between 16 and 123 inclusive
print_blocks 124 231 6 6 3 # 6x6x6 colour cube between 124 and 231 inclusive
print_blocks 232 255 12 2 1 # Not 50, but 24 Shades of Grey

The new output

The old output

Fixed by changing the last lines to this:

[
  (print_run 0 16) # The first 16 colours are spread over the whole spectrum
  (print "")             # Single line
  (print_blocks 16 123 6 6 3) # 6x6x6 colour cube between 16 and 123 inclusive
  (print_blocks 124 231 6 6 3) # 6x6x6 colour cube between 124 and 231 inclusive
  (print_blocks 232 255 12 2 1) # Not 50, but 24 Shades of Grey
] | str join (char nl)

2nd casualty. turtle.nu
This just doesn't look right. Maybe we need to capture the output in variables?

source turtle.nu
Turtle 1 = Turtle 2 = Turtle 3 = Turtle 4 = Turtle 5 = 2936

The script

# The infamous turtle benchmark
def turtle [column: string] {
    wrap $column | table
}

print -n "Turtle 1 = "
"turtle" | turtle 1 | str length
print -n "Turtle 2 = "
"turtle" | turtle 1 | turtle 2 | str length
print -n "Turtle 3 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | str length
print -n "Turtle 4 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | turtle 4 | str length
print -n "Turtle 5 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | turtle 4 | turtle 5 | str length

Fixed by changing the end part to this

[
    (print $"Turtle 1 = ('turtle' | turtle 1 | str length)")
    (print $"Turtle 2 = ('turtle' | turtle 1 | turtle 2 | str length)")
    (print $"Turtle 3 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | str length)")
    (print $"Turtle 4 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | str length)")
    (print $"Turtle 5 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | turtle 5 | str length)")
] | str join

And 3rd - my poor friend gradient.nu. The prime benchmark that started the craze.
There's no output at all. :(

I'm not sure what to do with gradient.nu because it wants to draw each row at a time. I actually would rather continually output on all the scripts versus collecting everything at the end. I don't think that's a good solution. We should be able to output iteratively.

Now that I think about it. I have some progress bar scripts that probably won't work either now.

@fdncred - what is print doing I wonder. Each print should go directly to the screen 🤔

Can you try this too:

print "hello"
print "world"

If you don't see both, I think we don't have it, yet.

2nd casualty. turtle.nu This just doesn't look right. Maybe we need to capture the output in variables?

source turtle.nu
Turtle 1 = Turtle 2 = Turtle 3 = Turtle 4 = Turtle 5 = 2936

The script

# The infamous turtle benchmark
def turtle [column: string] {
    wrap $column | table
}

print -n "Turtle 1 = "
"turtle" | turtle 1 | str length
print -n "Turtle 2 = "
"turtle" | turtle 1 | turtle 2 | str length
print -n "Turtle 3 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | str length
print -n "Turtle 4 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | turtle 4 | str length
print -n "Turtle 5 = "
"turtle" | turtle 1 | turtle 2 | turtle 3 | turtle 4 | turtle 5 | str length

Fixed by changing the end part to this

[
    (print $"Turtle 1 = ('turtle' | turtle 1 | str length)")
    (print $"Turtle 2 = ('turtle' | turtle 1 | turtle 2 | str length)")
    (print $"Turtle 3 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | str length)")
    (print $"Turtle 4 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | str length)")
    (print $"Turtle 5 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | turtle 5 | str length)")
] | str join

This one is correct now and needs print for the output of each. You could probably make them 'turtle' | turtle 1 | str length | print $in

@jntrnr I did this on turtle and it works

print $"Turtle 1 = ('turtle' | turtle 1 | str length)"
print $"Turtle 2 = ('turtle' | turtle 1 | turtle 2 | str length)"
print $"Turtle 3 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | str length)"
print $"Turtle 4 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | str length)"
print $"Turtle 5 = ('turtle' | turtle 1 | turtle 2 | turtle 3 | turtle 4 | turtle 5 | str length)"

and this on 256_color_testpattern and it works too

print (print_run 0 16) # The first 16 colours are spread over the whole spectrum
print ""             # Single line
print (print_blocks 16 123 6 6 3) # 6x6x6 colour cube between 16 and 123 inclusive
print (print_blocks 124 231 6 6 3) # 6x6x6 colour cube between 124 and 231 inclusive
print (print_blocks 232 255 12 2 1) # Not 50, but 24 Shades of Grey

and I changed thie one line in gradient and it seems to have fixed it
old line

    $"($row_data)(char newline)"

new line

    print -n $"($row_data)(char newline)"

Codecov Report

Merging #8292 (8e1e761) into main (8c487ed) will decrease coverage by 0.10%.
The diff coverage is 60.60%.

@@            Coverage Diff             @@
##             main    #8292      +/-   ##
==========================================
- Coverage   68.05%   67.96%   -0.10%     
==========================================
  Files         621      621              
  Lines       99938    99923      -15     
==========================================
- Hits        68015    67911     -104     
- Misses      31923    32012      +89     

Fixed everything except this python-virtualenv tests. Can't quite figure out what the problem is there. Output is not helpfull at all

Fixed everything except this python-virtualenv tests. Can't quite figure out what the problem is there. Output is not helpfull at all

Identified problem. To test prompt that shell is behaving correctly virtualenv tests is running a script created like this:

def _get_test_lines(self, activate_script):
        commands = [
            self.print_python_exe(),
            self.print_os_env_var("VIRTUAL_ENV"),
            self.activate_call(activate_script),
            self.print_python_exe(),
            self.print_os_env_var("VIRTUAL_ENV"),
            self.print_prompt(),
            # \\ loads documentation from the virtualenv site packages
            self.pydoc_call,
            self.deactivate,
            self.print_python_exe(),
            self.print_os_env_var("VIRTUAL_ENV"),
            "",  # just finish with an empty new line
        ]
        return commands

Which results in following nushell script:

python.EXE -c 'import sys; print(sys.executable)'
python.EXE -c 'import os; import sys; v = os.environ.get("VIRTUAL_ENV"); print(v)'
overlay use 'C:\Users\Artemiy\AppData\Local\Temp\pytest-of-unknown\pytest-3\activation-tester-env0\e-$ -j\Scripts\activate.nu'
python.EXE -c 'import sys; print(sys.executable)'
python.EXE -c 'import os; import sys; v = os.environ.get("VIRTUAL_ENV"); print(v)'
$env.VIRTUAL_PROMPT
pydoc -w pydoc_test
deactivate
python.EXE -c 'import sys; print(sys.executable)'
python.EXE -c 'import os; import sys; v = os.environ.get("VIRTUAL_ENV"); print(v)'

The problem here is that everything is printing to stdout except $env.VIRTUAL_PROMPT which by old rules is a separate pipeline that is echoed. But by new rules it does nothing. To fix this a small change is needed in test_nushell.py, change print_prompt function to

def print_prompt(self):
      return r"print $env.VIRTUAL_PROMPT"

to print that output.

I think I will need to PR to virtualenv repository to resolve this issue.

I haven't followed this PR in detail, but you can make PR to virtualenv. Regardless of this PR getting merged or not, adding print there shouldn't hurt anything.

I personally support not auto-printing intermediate pipelines, only the last one.

Btw, what happens if you have nested blocks? Like do { do { 'spam' }; 'bar' }.

I haven't followed this PR in detail, but you can make PR to virtualenv. Regardless of this PR getting merged or not, adding print there shouldn't hurt anything.

Will do!

I personally support not auto-printing intermediate pipelines, only the last one.

Btw, what happens if you have nested blocks? Like do { do { 'spam' }; 'bar' }.

Inner do will return 'spam'. Outer will execute inner do, get return value and discard it. Then it will return 'bar':

Cool, to me, this behavior seems good 👍

For the virtualenv PR, you'll need to add a changelog entry as well. You can check previous PRs in the virtualenv repo done by me, or one open just now by WindSoilder, for reference.

I think we're ready to try again with this PR. Can you fix the conflicts and then we'll let CI run again and see if it goes through.

I think we're ready to try again with this PR. Can you fix the conflicts and then we'll let CI run again and see if it goes through.

Done. I think it is ready for merge