update code coversage script to work better with windows#8141
Merged
sholderbach merged 1 commit intonushell:mainfrom Feb 20, 2023
fdncred:update_coverage_script
Merged
update code coversage script to work better with windows#8141sholderbach merged 1 commit intonushell:mainfrom fdncred:update_coverage_script
sholderbach merged 1 commit intonushell:mainfrom
fdncred:update_coverage_script
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8141 +/- ##
==========================================
- Coverage 54.61% 54.23% -0.39%
==========================================
Files 608 608
Lines 99005 99009 +4
==========================================
- Hits 54070 53695 -375
- Misses 44935 45314 +379
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code coverage script to help it work better on Windows. The main changes here are to give you some progress outputs and to enable
cargo llvm-cov show-env | from tomlto work better since the toml spec says these literal strings should be single quoted vs double quoted.Closed #8139
User-Facing Changes
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.