Fix && quotation in to nuon after proptest fail#7564
Merged
sholderbach merged 3 commits intonushell:mainfrom Dec 21, 2022
Merged
Fix && quotation in to nuon after proptest fail#7564sholderbach merged 3 commits intonushell:mainfrom
&& quotation in to nuon after proptest fail#7564sholderbach merged 3 commits intonushell:mainfrom
Conversation
`proptest` caught a failing test condition for `&&` as a literal string. https://github.com/nushell/nushell/actions/runs/3753242377/jobs/6376308675 The change in the parser that now returns an error was introduced by nushell#7241 This in theory doesn't have to be an error but it is probably better safe than sorry to require quotation here.
Requires a quotation to be parsed by current `from nuon` Only required since nushell#7241 Include a comment stating that this is due to a zealous diagnostic
Should be properly quoted to be a valid string
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Mar 31, 2023
The two tests `to_nuon_from_nuon` and `to_nuon_from_nuon_string` were taking multiple seconds and have since been superseded by more explicit unit tests. Compared to the time cost for devs and CI they seldomly returned explicit problems. One failure only popped up after months, as a sampled failure (nushell#7564). Fuzzing should move to a separate worker and be removed from the main test suite. See nushell#8575 for experimentation around the impact on our test coverage.
sholderbach
added a commit
that referenced
this pull request
Mar 31, 2023
# Description The two tests `to_nuon_from_nuon` and `to_nuon_from_nuon_string` were taking multiple seconds and have since been superseded by more explicit unit tests. Compared to the time cost for devs and CI they seldomly returned explicit problems. One failure only popped up after months, as a sampled failure (#7564). # User-Facing Changes none # Tests + Formatting Fuzzing should move to a separate worker and be removed from the main test suite. See #8575 for experimentation around the impact on our test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proptestcaught a failing test condition for&&as a literal string. It requires a quotation to be parsed correctly by currentfrom nuonhttps://github.com/nushell/nushell/actions/runs/3753242377/jobs/6376308675
The change in the parser that now returns an error was introduced by #7241
This in theory doesn't have to be an error (it is a diagnostic for nushell code) but it is probably better safe than sorry to require quotation here.
&&into nuonfrom proptest failto nuongenerating invalid&&literal,into nuon/from nuoncycleTests + Formatting
Added previous proptest failure as part of a integration test