ensure get doesn't delve too deep in nested lists#7497
Merged
rgwood merged 2 commits intonushell:mainfrom Dec 16, 2022
Merged
Conversation
Contributor
|
Nice, thank you for the quick fix! That looks good to me once the tests pass; I think we have some tests that (strangely enough) depend on the current behaviour. |
Contributor
|
[ [{ foo: "bar" }] ] | get 0 | to nuon [[foo]; [bar]] [ [{ foo: "bar" }] ] | get 0.foo | to nuon [bar] This should continue to work after this fix though... |
Contributor
|
@stormasm Those commands return the same thing as before this PR. |
rgwood
approved these changes
Dec 16, 2022
Contributor
|
@rgwood cool ! thanks for checking... |
rgwood
added a commit
that referenced
this pull request
Dec 17, 2022
A follow-up to #7497. That change made it so that `get foo` would eliminate non-record rows; I think that was an unintentional and undesirable side-effect. Before #7497: ```bash 〉[$nothing, { item: "foo" }] | get item ╭───┬─────╮ │ 0 │ │ │ 1 │ foo │ ╰───┴─────╯ ``` After #7497: ```bash 〉[$nothing, {item: "foo"}] | get item ╭───┬─────╮ │ 0 │ foo │ ╰───┴─────╯ ``` After this PR: ```bash 〉[$nothing, { item: "foo" }] | get item ╭───┬─────╮ │ 0 │ │ │ 1 │ foo │ ╰───┴─────╯ ``` cc: @merelymyself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7494.
User-Facing Changes
cell paths no longer drill into nested tables.
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.