Conversation
|
I think this is a great idea but IMO it should be more robust. I can see a couple of points where the command would fail:
I keep thinking we shouldn't add new logic handling these cases because that would be just duplicating the logic that's already in the parser. What I would try:
Stuff like that is generally not safe, but I think this should OK because the I'm going to merge this because it is an improvement over the current state but the above points should eventually be addressed. |
This reverts commit f0e93c2.
This reverts commit f0e93c2 (PR #7417). I'm currently [working on improving cell paths](#7498 (comment)), and I realized that I would need to make several improvements to `into cellpath` along the lines of Jakub's comment here: #7417 (comment) I don't think `into cellpath` is quite ready for prime-time, and I'd like to remove it before the upcoming release.
|
Thanks for the PR, @Kangaxx-0. I reverted this for now because I'm working on some cell path improvements and the duplicated parser logic in We'd welcome another PR to add this back with the improvements that @kubouch suggested (but if you're going to do that, maybe wait a little bit to avoid conflicts; my cell path changes will hopefully be done in the next couple days). |
I get the basic idea that comment is asking, however, I don't feel confident to reparse input during |
Using |
I tried this and it was too difficult to get it to work. JT also didn't think we should do it as it comes too close to eval. |
Description
Address part of feature request #7337, add a small command
into cellpathto allow string -> cellpath auto-conversion, with this change, we could runNote - This pr only covers
String->CellPath, any other conversions should be considered as expected?Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.