Skip to content

Remove uses of nightly Rust, switch compiler to beta#724

Merged
sophiajt merged 5 commits intonushell:masterfrom
est31:stable_async
Sep 28, 2019
Merged

Remove uses of nightly Rust, switch compiler to beta#724
sophiajt merged 5 commits intonushell:masterfrom
est31:stable_async

Conversation

@est31
Copy link
Contributor

@est31 est31 commented Sep 28, 2019

This removes the last remaining dependencies on nightly Rust and switches the pinned nightly to the beta toolchain. Once 1.39.0 is released, the pin can be removed.

Closes #362

@sophiajt
Copy link
Contributor

@est31 wow! That's awesome!

@est31
Copy link
Contributor Author

est31 commented Sep 28, 2019

Hmmm I just now discovered that language-reporting uses nightly Rust... will have to file a PR for language-reporting before this is ready for merging.

@sophiajt
Copy link
Contributor

cc @wycats about language-reporting using nightly

@est31
Copy link
Contributor Author

est31 commented Sep 28, 2019

The PR has been filed: wycats/language-reporting#7

I have also updated this PR to use it.

@wycats
Copy link
Contributor

wycats commented Sep 28, 2019

I merged language-reporting

@est31 est31 mentioned this pull request Sep 28, 2019
12 tasks
@sophiajt sophiajt merged commit ddcf0b4 into nushell:master Sep 28, 2019
elferherrera added a commit to elferherrera/nushell that referenced this pull request Feb 7, 2022
kubouch pushed a commit that referenced this pull request Feb 7, 2022
Hofer-Julian pushed a commit to Hofer-Julian/nushell that referenced this pull request Jan 27, 2023
If I'm understanding that correctly from [this PR](nushell#7052) `command_type` should be `plugin` if it comes from a plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Target stable Rust

3 participants