Use effectively unlimited history size if not set#5587
Merged
fdncred merged 1 commit intonushell:mainfrom May 19, 2022
Merged
Conversation
Contributor
|
i64:max - would love to see a history that size! lol |
3 tasks
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
May 20, 2022
Fixes nushell#5593 OOM introduced with nushell#5587 when no config was present and an attempt was made to allocate all memory in advance Includes also other changes to reedline: - Vi word definition fixed and `w` and `e` work as expected
sholderbach
added a commit
that referenced
this pull request
May 20, 2022
fennewald
pushed a commit
to fennewald/nushell
that referenced
this pull request
Jun 27, 2022
fennewald
pushed a commit
to fennewald/nushell
that referenced
this pull request
Jun 27, 2022
Fixes nushell#5593 (OOM introduced with nushell#5587 when no config was present and an attempt was made to allocate all memory in advance) Includes also other changes to reedline: - Vi word definition fixed and `w` and `e` work as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5586
Tests
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all the tests pass