Remove usage of in_band_lifetimes feature#527
Merged
sophiajt merged 1 commit intonushell:masterfrom Aug 29, 2019
Merged
Conversation
Contributor
|
I don't really want to remove in-band lifetimes 😢 😭 |
Contributor
Author
Contributor
|
@taiki-e - would it make sense to merge what we have now rather than re-do it? |
Contributor
|
@wycats - I wonder how close it is to becoming stable in rustc |
Contributor
|
I'm ok with removing in-band lifetimes, as sad as it makes me. Stable Rust is important. |
Contributor
Author
|
I'm fine with either one (this is a small work). |
Contributor
|
@taiki-e - if you want to resolve the conflict, I'll go ahead and land this |
24c4949 to
58a3249
Compare
Contributor
Author
|
Resolved the conflict. |
Contributor
|
Thanks! |
elferherrera
added a commit
to elferherrera/nushell
that referenced
this pull request
Feb 7, 2022
* nothing variable * corrected comments * added color to nothing like bool * compare nothing with values * comparison tests
kubouch
pushed a commit
that referenced
this pull request
Feb 7, 2022
* nothing variable * corrected comments * added color to nothing like bool * compare nothing with values * comparison tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #362