Remove a few unused dependencies #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Removal of rand 0.5 depends on sru-systems/rust-argon2#20 or https://gitlab.redox-os.org/redox-os/users/issues/26 (optimally both get fixed as then we won't need rust-argon2 at all). |
Contributor
|
Thanks! |
Merged
|
I'd like to say that I am very glad to see that nushell is taking care to reduce the number of dependencies. That was certainly something I was thinking about while installing it the first time. |
Hofer-Julian
pushed a commit
to Hofer-Julian/nushell
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cat Cargo.lock | rg '"checksum ' | wc -lbefore this PR: 405. After this PR: 382. So in total, 23 less dependencies. And there are even 27 less crates that Cargo has to build, probably because some crates are used both as build dependency and as usual dependency.