Conversation
| fn external_arg_with_quotes() { | ||
| Playground::setup("external_arg_with_quotes", |dirs, sandbox| { | ||
| sandbox.with_files(vec![FileWithContent( | ||
| "sample.toml", |
There was a problem hiding this comment.
@jonathandturner, I'm wondering what happens if the path contains spaces? Or do you tackle this case in another issue?
There was a problem hiding this comment.
Paths with spaces should work. I've done a few completion updates, which includes improving how we handle paths with spaces.
Are you seeing any issues with the latest PRs?
There was a problem hiding this comment.
My thought was that the test could reflect that spaces are supported. Like that:
| "sample.toml", | |
| "a sample file.toml", |
So, I don't see any trouble, just a slight test code improvement.
There was a problem hiding this comment.
@schrieveslaach if you're interested, we'd love to have more tests to help cover cases like that.
There was a problem hiding this comment.
@jonathandturner, I created #3596, do you mind and have a look at it?
This PR:
catfixes #3329