Add Test Case for Special Character Paths#3596
Merged
sophiajt merged 1 commit intonushell:mainfrom Jun 28, 2021
Merged
Conversation
schrieveslaach
commented
Jun 10, 2021
34938ab to
f8b2680
Compare
2a89167 to
7e9d02c
Compare
Added test cases that ensure that special characters in path names are passed to external commands correctly. These cases have been implemented with rstest to reuse existing test code.
7e9d02c to
194f428
Compare
Contributor
Author
|
Rebased and tests are working. I think this PR is ready for review |
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases that ensure that special characters in path names are passed to external commands correctly. These cases have been implemented with rstest to reuse existing test code.