fix bare interpolation regression#16235
Merged
Bahex merged 3 commits intonushell:mainfrom Jul 25, 2025
Merged
Conversation
sholderbach
approved these changes
Jul 24, 2025
Member
sholderbach
left a comment
There was a problem hiding this comment.
Based on your comments in #16204 this sounds good at first glance.
The test is thorough, with a slightly high tax should we change something in the AST representation, we should probably have a plan ready to make sure we port tests like these ahead of refactors to a more agnostic style.
Minor comment: may be worth adding an issue number in a comment to the test.
Member
Author
|
We don't actually have an issue for the regression this PR fixes, so I'll add a more through description here and add the number of the PR instead. |
Bahex
added a commit
that referenced
this pull request
Jul 29, 2025
Regression from #16204 Before:  After:  # Tests + Formatting +1 --------- Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
sholderbach
pushed a commit
to sholderbach/nushell
that referenced
this pull request
Jul 29, 2025
Regression from nushell#16204 Before:  After:  # Tests + Formatting +1 --------- Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Aug 25, 2025
Regression from nushell#16204 Before:  After:  # Tests + Formatting +1 --------- Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #16204
Before:
After:
Tests + Formatting
+1