fix(overlay): overlay use and overlay hide now update config state#16154
Merged
Bahex merged 2 commits intonushell:mainfrom Jul 12, 2025
Merged
fix(overlay): overlay use and overlay hide now update config state#16154Bahex merged 2 commits intonushell:mainfrom
overlay use and overlay hide now update config state#16154Bahex merged 2 commits intonushell:mainfrom
Conversation
use overlay and hide overlay now update config stateoverlay use and overlay hide now update config state
Contributor
|
wow, a 2 line change. 🚀 |
Member
|
It's a beauty when plans err... well refined APIs come together :) As there were so many issues reporting it, can we come up with a few basic tests? |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Aug 25, 2025
nushell#16154) - fixes nushell#5986 - fixes nushell#7760 - fixes nushell#8856 - fixes nushell#10592 - fixes nushell#11082 # Description Unconditionally update the config state after each `overlay use` and `overlay hide`. The fix looks simple, but only because of the constant improvements and refactors to the codebase that have taken place over time made it possible. Fixing these issue when they were initially filed would have been much harder. # User-Facing Changes Overlays can add hooks, change color_config, update the config in general. # Tests + Formatting No tests added as I still haven't figured out how to simulate the repl in tests. # After Submitting N/A --------- Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export-env#8856Description
Unconditionally update the config state after each
overlay useandoverlay hide.The fix looks simple, but only because of the constant improvements and refactors to the codebase that have taken place over time made it possible.
Fixing these issue when they were initially filed would have been much harder.
User-Facing Changes
Overlays can add hooks, change color_config, update the config in general.
Tests + Formatting
No tests added as I still haven't figured out how to simulate the repl in tests.
After Submitting
N/A