Add warning when using history isolation with non-SQLite history format#16151
Merged
Bahex merged 4 commits intonushell:mainfrom Jul 15, 2025
Merged
Add warning when using history isolation with non-SQLite history format#16151Bahex merged 4 commits intonushell:mainfrom
Bahex merged 4 commits intonushell:mainfrom
Conversation
|
Hey, just a bot checking in! You edited files related to the configuration. |
sholderbach
reviewed
Jul 10, 2025
Member
sholderbach
left a comment
There was a problem hiding this comment.
Good observation about the often raised confusion and good exercise of your reworked warning system.
At the same time with our fault recovering config system, should this be a warning or simply a hard error?
Member
Author
|
I think it's reasonable for this to be warning because
|
Bahex
approved these changes
Jul 10, 2025
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Aug 25, 2025
…at (nushell#16151) # Description This PR depends on nushell#16147, use `git diff 132ikl/shell-warning 132ikl/isolation-warn` to see only changes from this PR People seem to get tripped up by this a lot, and it's not exactly intuitive, so I added a warning if you try to set `$env.config.history.isolation = true` when using the plaintext file format: Warning: nu::shell::invalid_config ⚠ Encountered 1 warnings(s) when updating config Warning: nu::shell::incompatible_options ⚠ Incompatible options ╭─[source:1:33] 1 │ $env.config.history.isolation = true · ──┬─ · ╰── history isolation only compatible with SQLite format ╰──── help: disable history isolation, or set $env.config.history.file_format = "sqlite" # User-Facing Changes * Added a warning when using history isolation without using SQLite history. # Tests + Formatting Added a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #16147, use
git diff 132ikl/shell-warning 132ikl/isolation-warnto see only changes from this PRPeople seem to get tripped up by this a lot, and it's not exactly intuitive, so I added a warning if you try to set
$env.config.history.isolation = truewhen using the plaintext file format:User-Facing Changes
Tests + Formatting
Added a test
After Submitting
N/A