Allow dashes in experimental option identifiers#16093
Merged
Bahex merged 1 commit intonushell:mainfrom Jul 2, 2025
Merged
Conversation
Bahex
approved these changes
Jul 2, 2025
mkatychev
pushed a commit
to mkatychev/nushell
that referenced
this pull request
Jul 2, 2025
# Description In nushell#16028 I also added a test to check that identifiers are valid to ensure that we have consistency there. But I only checked for alphanumeric strings as identifiers. It doesn't allow underscores or dashes. @Bahex used in his PR about nushell#15682 a dash to separate words. So expanded the test to allow that. # User-Facing Changes None. # Tests + Formatting The `assert_identifiers_are_valid` now allows dashes. # After Submitting The tests in nushell#15682 should work then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #16028 I also added a test to check that identifiers are valid to ensure that we have consistency there. But I only checked for alphanumeric strings as identifiers. It doesn't allow underscores or dashes. @Bahex used in his PR about #15682 a dash to separate words. So expanded the test to allow that.
User-Facing Changes
None.
Tests + Formatting
The
assert_identifiers_are_validnow allows dashes.After Submitting
The tests in #15682 should work then.