Skip to content

Change escape function in parser#13022

Closed
kubouch wants to merge 1 commit intonushell:mainfrom
kubouch:fix-external-escape
Closed

Change escape function in parser#13022
kubouch wants to merge 1 commit intonushell:mainfrom
kubouch:fix-external-escape

Conversation

@kubouch
Copy link
Copy Markdown
Contributor

@kubouch kubouch commented May 31, 2024

Description

Attempts to fix #13016. Needs more testing, but it appears to fix the issue of running C:\Windows\System32\cmd.exe on Windows. It also doesn't break running ~/.config/bin/nu.

User-Facing Changes

Tests + Formatting

After Submitting

@kubouch kubouch closed this Jun 1, 2024
kubouch pushed a commit that referenced this pull request Jun 3, 2024
…3027)

# Description

Fixes #13016 and adds tests for many variations of external call
parsing.

I just realized @kubouch took a crack at this too (#13022) so really
whichever is better, but I think the
tests are a good addition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nushell 0.94.1 breaks Windows path handling

1 participant