Fix the way the output of table is printed in print()#12895
Merged
devyn merged 1 commit intonushell:mainfrom May 17, 2024
Merged
Fix the way the output of table is printed in print()#12895devyn merged 1 commit intonushell:mainfrom
table is printed in print()#12895devyn merged 1 commit intonushell:mainfrom
Conversation
FilipAndersson245
pushed a commit
to FilipAndersson245/nushell
that referenced
this pull request
May 18, 2024
) # Description Forgot that I fixed this already on my branch, but when printing without a display output hook, the implicit call to `table` gets its output mangled with newlines (since nushell#12774). This happens when running `nu -c` or a script file. Here's that fix in one PR so it can be merged easily. # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forgot that I fixed this already on my branch, but when printing without a display output hook, the implicit call to
tablegets its output mangled with newlines (since #12774). This happens when runningnu -cor a script file.Here's that fix in one PR so it can be merged easily.
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlib