Skip to content

deprecate str escape-glob command#12018

Merged
WindSoilder merged 1 commit intonushell:mainfrom
WindSoilder:glob_escape
Feb 29, 2024
Merged

deprecate str escape-glob command#12018
WindSoilder merged 1 commit intonushell:mainfrom
WindSoilder:glob_escape

Conversation

@WindSoilder
Copy link
Copy Markdown
Contributor

Description

After some iteration on globbing rules, I don't think str escape-glob is needed

User-Facing Changes

 let f = "[ab]*.nu"
 $f | str escape-glob
Error:   × str escape-glob is deprecated
   ╭─[entry #1:1:6]
 1  $f | str escape-glob
   ·      ───────┬───────
   ·             ╰── if you are trying to escape a variable, you don't need to do it now
   ╰────
  help: Remove `str escape-glob` call

[[]ab[]][*].nu

Tests + Formatting

NaN

After Submitting

NaN

@WindSoilder WindSoilder added category:deprecation Related to the deprecation of commands/features/options category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal labels Feb 29, 2024
@WindSoilder WindSoilder merged commit 65e5aba into nushell:main Feb 29, 2024
@hustcer hustcer added this to the v0.91.0 milestone Mar 1, 2024
@sholderbach sholderbach removed the category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal label Mar 20, 2024
FilipAndersson245 pushed a commit to FilipAndersson245/nushell that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:deprecation Related to the deprecation of commands/features/options

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants