fix custom command's default value#11043
Merged
sholderbach merged 5 commits intonushell:mainfrom Nov 14, 2023
Merged
Conversation
…it_type correctly
sholderbach
approved these changes
Nov 14, 2023
Member
sholderbach
left a comment
There was a problem hiding this comment.
With the caveat that the whole parse_signature_helper is an absolute monster that I can not really reason about by "just looking at it".
The diff looks good to me and the added and old tests pass, so I think we are good to go.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description Fixes: nushell#11033 Sorry for the issue, it's a regression which introduce by this pr: nushell#10456. And this pr is going to fix it. About the change: create a new field named `type_annotated` for `Arg::Flag` and `Arg::Signature` instead of `arg_explicit_type` variable. When we meet a type in `TypeMode`, we set `type_annotated` field of the argument to be true, then we know that if the arg have a annotated type easily
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description Fixes: nushell#11033 Sorry for the issue, it's a regression which introduce by this pr: nushell#10456. And this pr is going to fix it. About the change: create a new field named `type_annotated` for `Arg::Flag` and `Arg::Signature` instead of `arg_explicit_type` variable. When we meet a type in `TypeMode`, we set `type_annotated` field of the argument to be true, then we know that if the arg have a annotated type easily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11033
Sorry for the issue, it's a regression which introduce by this pr: #10456.
And this pr is going to fix it.
About the change: create a new field named
type_annotatedforArg::FlagandArg::Signatureinstead ofarg_explicit_typevariable.When we meet a type in
TypeMode, we settype_annotatedfield of the argument to be true, then we know that if the arg have a annotated type easily