Refactor find in terms of clean Record API#10929
Merged
sholderbach merged 3 commits intonushell:mainfrom Nov 8, 2023
Merged
Conversation
`record_matches_term()` was checking if the record columns contain the record columns if not narrowed to specific columns. Don't do that and only perform the `contains()` check if given a set of columns.
- Remove quadratic lookup if not given narrowing columns - Use a single `.iter_mut` loop to perform the highlighting instead of iter(tools) chaining.
Member
Author
|
Performance measured with 1..1000 | each { scope commands | timeit { find 42 } } | math avgas Before (base commit)
With this
|
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description Rewrite `find` internals with the same principles as in nushell#10927. Here we can remove an unnecessary lookup accross all columns when not narrowing find to particular columns - Change `find` internal fns to use iterators - Remove unnecessary quadratic lookup in `find` - Refactor `find` record highlight logic # User-Facing Changes Should provide a small speedup when not providing `find --columns` # Tests + Formatting (-)
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description Rewrite `find` internals with the same principles as in nushell#10927. Here we can remove an unnecessary lookup accross all columns when not narrowing find to particular columns - Change `find` internal fns to use iterators - Remove unnecessary quadratic lookup in `find` - Refactor `find` record highlight logic # User-Facing Changes Should provide a small speedup when not providing `find --columns` # Tests + Formatting (-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrite
findinternals with the same principles as in #10927.Here we can remove an unnecessary lookup accross all columns when not narrowing find to particular columns
findinternal fns to use iteratorsfindfindrecord highlight logicUser-Facing Changes
Should provide a small speedup when not providing
find --columnsTests + Formatting
(-)