Refactor env conversion to eliminate Value::follow_cell_path_not_from_user_input#10926
Merged
sholderbach merged 3 commits intonushell:mainfrom Nov 8, 2023
Merged
Refactor env conversion to eliminate Value::follow_cell_path_not_from_user_input#10926sholderbach merged 3 commits intonushell:mainfrom
Value::follow_cell_path_not_from_user_input#10926sholderbach merged 3 commits intonushell:mainfrom
Conversation
IanManske
commented
Nov 2, 2023
sholderbach
approved these changes
Nov 8, 2023
Comment on lines
+373
to
+376
| .and_then(|val| val.as_record().ok()) | ||
| .and_then(|record| record.get(name)) | ||
| .and_then(|val| val.as_record().ok()) | ||
| .and_then(|record| record.get(direction)); |
Member
Author
|
Hmm... I'm not sure why but I'm getting some jarbbled error output if the conversion is not a closure. And it only happens on the fourth time I press enter (I think once the text reaches the bottom of the terminal). Should we treat this as a separate issue? |
Member
Can you reproduce something similar on To me it looks like it is outputting while the terminal is still in raw mode so the carriage return is not automatically added for I think worth filing a separate issue. |
sholderbach
added a commit
that referenced
this pull request
Nov 8, 2023
# Description This is pretty complementary/orthogonal to @IanManske 's changes to `Value` cellpath accessors in: - #10925 - to a lesser extent #10926 ## Steps - Use `R.remove` in `Value.remove_data_at_cell_path` - Pretty sound after #10875 (tests mentioned in commit message have been removed by that) - Update `did_you_mean` helper to use iterator - Change `Value::columns` to return iterator - This is not a place of honor - Use `Record::get` in `Value::get_data_by_key` # User-Facing Changes None intentional, potential edge cases on duplicated columns could change (considered undefined behavior) # Tests + Formatting (-)
Member
Author
|
Ok, opened a separate issue. That one was a doozy to figure out. |
Member
|
Let's go with this! |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description This is pretty complementary/orthogonal to @IanManske 's changes to `Value` cellpath accessors in: - nushell#10925 - to a lesser extent nushell#10926 ## Steps - Use `R.remove` in `Value.remove_data_at_cell_path` - Pretty sound after nushell#10875 (tests mentioned in commit message have been removed by that) - Update `did_you_mean` helper to use iterator - Change `Value::columns` to return iterator - This is not a place of honor - Use `Record::get` in `Value::get_data_by_key` # User-Facing Changes None intentional, potential edge cases on duplicated columns could change (considered undefined behavior) # Tests + Formatting (-)
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
…ll#10926) # Description Replaces the only usage of `Value::follow_cell_path_not_from_user_input` with some `Record::get`s. # User-Facing Changes Breaking change for `nu-protocol`, since `Value::follow_cell_path_not_from_user_input` was deleted. Nushell now reports errors for when environment conversions are not closures.
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description This is pretty complementary/orthogonal to @IanManske 's changes to `Value` cellpath accessors in: - nushell#10925 - to a lesser extent nushell#10926 ## Steps - Use `R.remove` in `Value.remove_data_at_cell_path` - Pretty sound after nushell#10875 (tests mentioned in commit message have been removed by that) - Update `did_you_mean` helper to use iterator - Change `Value::columns` to return iterator - This is not a place of honor - Use `Record::get` in `Value::get_data_by_key` # User-Facing Changes None intentional, potential edge cases on duplicated columns could change (considered undefined behavior) # Tests + Formatting (-)
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
…ll#10926) # Description Replaces the only usage of `Value::follow_cell_path_not_from_user_input` with some `Record::get`s. # User-Facing Changes Breaking change for `nu-protocol`, since `Value::follow_cell_path_not_from_user_input` was deleted. Nushell now reports errors for when environment conversions are not closures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the only usage of
Value::follow_cell_path_not_from_user_inputwith someRecord::gets.User-Facing Changes
Breaking change for
nu-protocol, sinceValue::follow_cell_path_not_from_user_inputwas deleted.Nushell now reports errors for when environment conversions are not closures.