Use int type name consistently#10579
Conversation
Missed those in nushell#10520 moved and fixed the tests so they will work in the future
Update commandline and its associated test
amtoine
left a comment
There was a problem hiding this comment.
ooh nice, thanks for working on this 🙏
i see there are still quite a few mentions to integer on the tip of this PR branch, is that expected and out of the scope of this PR? 😋
e.g.
crates/nu-command/src/generators/seq_date.rs
286: "integer value too large".to_string(),
287: "integer value too large".to_string(),
|
also, you're first bullet point above will supersed one of the commits of #10568, which is fine 😉 |
I skipped a bunch of places where it being a nushell type For the example you found we could shorten that as well. |
amtoine
left a comment
There was a problem hiding this comment.
i had a quick look at the remaining results from rg integer crates/**/*.rs and it looked mostly fine to me 👌
thanks for the increased consistency 🙏
# Description When referring to the type use `int` consistently. Only when referring to the concept of integer numbers use `integer`. - Fix `random integer` to `random int` tests - Forgot in nushell#10520 - Use int instead of integer in error messages - Use int type name in bits commands - Fix messages in `for` examples - Use int typename in `into` commands - Use int typename in rest of commands - Report errors in `nu-protocol` with int typename Work for nushell#10332 # User-Facing Changes User errorrs should now use `int` so you can easily find the necessary commands or type annotations. # Tests + Formatting Only two tests found that needed updating
Description
When referring to the type use
intconsistently. Only when referring to the concept of integer numbers useinteger.random integertorandom inttestsrandom integertorandom int#10520forexamplesintocommandsnu-protocolwith int typenameWork for #10332
User-Facing Changes
User errorrs should now use
intso you can easily find the necessary commands or type annotations.Tests + Formatting
Only two tests found that needed updating