Allow filesystem commands to access files with glob metachars in name by bobhy · Pull Request #10557 · nushell/nushell

bobhy · 2023-09-30T07:39:39Z

MEGA-EDIT:
Completely changing goals of this PR!
Work to date has found a fix for a good bug, but the original idea of supporting {} brace expansion like bash no longer seems achievable as a globbing enhancement. So this PR is now all about:

Fix problem #10571.

Description

before: Args to cp, mv, rm are assumed to be globs within each command. That means a file that looks like a glob is not matched by the glob and takes some thinking about to access. That is, the glob pattern shadows a file with the same spelling.

> ls a*
╭───┬────────┬──────┬──────┬────────────────╮
│ # │  name  │ type │ size │    modified    │
├───┼────────┼──────┼──────┼────────────────┤
│ 0 │ a[bc]d │ file │  0 B │ 34 seconds ago │
│ 1 │ abd    │ file │  0 B │ now            │
│ 2 │ acd    │ file │  0 B │ now            │
╰───┴────────┴──────┴──────┴────────────────╯

> cp --verbose 'a[bc]d' dest
copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd
copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd

> ## Note -- a[bc]d *not* copied, and seemingly hard to access.
> cp --verbose 'a\[bc\]d' dest
Error:   × No matches found
   ╭─[entry #33:1:1]
 1 │ cp --verbose 'a\[bc\]d' dest
   ·              ─────┬────
   ·                   ╰── no matches found
   ╰────

> #.. but not completely inaccessible.
> cp --verbose 'a[[]bc[]]d' dest
copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d

Before_2: if file has glob metachars but isn't a valid pattern, user gets a confusing error:

> touch 'a[b'
> cp 'a[b' dest
Error:   × Pattern syntax error near position 30: invalid range pattern
   ╭─[entry #13:1:1]
 1 │ cp 'a[b' dest
   ·    ──┬──
   ·      ╰── invalid pattern
   ╰────

After: Args to cp, mv, etc. are tried first as literal files, and only as globs if not found to be files.

> cp --verbose 'a[bc]d' dest
copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d
> cp --verbose '[a][bc]d' dest
copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd
copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd

After_2: file with glob metachars but invalid pattern just works (though the name probably requires string quotes)

> cp --verbose 'a[b' dest
copied /home/bobhy/src/rust/work/r4/a[b to /home/bobhy/src/rust/work/r4/dest/a[b

So, with this fix, a file shadows a glob pattern with the same spelling. You must invent some other spelling for the glob pattern to match the desired files. I think that's less confusing to the user: if ls shows a file with a weird name, s/he'll still be able to copy, rename or delete it.

;tl;dr

Original title: Enable {} glob metachars in command arguments

... To make nu feel more like csh.
Fixes #10498.

So far, only ucp command has been touched, as a proof of concept. But we should proceed through the rest of the filesystem commands.

This PR uses crate wax for globbing instead of fixing the internal crate nu_glob. Once all the clients are upgraded, nu_glob could be deprecated.

Description

Enables glob alternation to be used in command line arguments (where arguments are supposed to refer to paths in filesystem).
e.g:

> ucp cr{awl,eep}.txt dest
> ls dest
╭───┬────────────────┬──────┬──────┬───────────────╮
│ # │      name      │ type │ size │   modified    │
├───┼────────────────┼──────┼──────┼───────────────┤
│ 0 │ dest/crawl.txt │ file │  0 B │ 2 minutes ago │
│ 1 │ dest/creep.txt │ file │  0 B │ 2 minutes ago │
╰───┴────────────────┴──────┴──────┴───────────────╯

{ and } are nu parser tokens, so must be quoted if they are not embedded within the glob.

> ucp '{crawl,hobble,sprint}.txt' dest
> ls dest
╭───┬─────────────────┬──────┬──────┬────────────────╮
│ # │      name       │ type │ size │    modified    │
├───┼─────────────────┼──────┼──────┼────────────────┤
│ 0 │ dest/crawl.txt  │ file │  0 B │ 11 seconds ago │
│ 1 │ dest/hobble.txt │ file │  0 B │ 11 seconds ago │
│ 2 │ dest/sprint.txt │ file │  0 B │ 11 seconds ago │
╰───┴─────────────────┴──────┴──────┴────────────────╯

Note that alternation works for more than 2 alternatives, as shown above.

User-Facing Changes

Currently, the new metachars can only be used in ucp command.

All uses of the old metachars should give same results as they used to, so no breaking changes.
Small changes to error messages when a glob fails to match anything.

Tests + Formatting

🟢 toolkit fmt
🟢 toolkit clippy
🟢 toolkit test
🟢 toolkit test stdlib

After Submitting

fdncred · 2023-09-30T12:26:25Z

Our friendly neighborhood windows CI strikes again. Without looking further, I have 2 guesses why it's failing.

Paths are in double quotes so with "C:\path\to\file" all "\" become escapes.
There's a mixture of slashes with 'C:\path/to/file.txt'.
I've seen both of these scenarios fail sometimes.

Generally, I think this PR is cool.

bobhy · 2023-09-30T17:18:16Z

I see a couple of problems. Firing up my Windows dev environment, which is a performance hit all of its own...

crates/nu-cmd-base/src/arg_glob.rs

fdncred · 2023-09-30T23:38:37Z

crates/nu-cmd-base/src/arg_glob.rs

+    let processed_pattern = pattern
+        .item
+        .replace('\\', "/")
+        .replace(r#":/"#, r#"\:/"#) // must come after above
+        .replace('(', r#"\("#) // when path includes Program Files (x86)
+        .replace(')', r#"\)"#);


I'm wondering what effect this will have on paths with spaces like Program Files and Program Files (x86). I see that lots of things are being replaced here but I'm not sure how that affects things here with these particular paths.

Embedded spaces won't be affected by these changes. A pattern or simple path with an embedded space would have to be enclosed in quotes anyway. It has been tested and works with C:\Program Files (x86)\*!

ok, thanks for the explanation. I'm wondering if it matters that this is different than how we cd to folders with spaces in them now, and that is with surrounding the path in backticks, which I think, does some bare word magic. I don't really follow how JT made it work. Just wondering if it matters here.

crates/nu-cmd-base/src/arg_glob.rs

esp rooted patterns with device or unc share into legit glob paths.

sophiajt · 2023-10-01T05:34:33Z

We have to be careful with adding glob syntax. Anything that's part of a valid filename on any of our platforms can't be used.

Can you confirm that { isn't part of a valid filename on Linux, Windows, and macOS?

bobhy · 2023-10-01T05:44:18Z

A key point of this change is to be able to use a simple file path or a glob pattern as argument to a filesystem command like ucp. That means that normal looking file paths have to be parsable as glob patterns (they will match just one file).

That's a problem on Windows, were backslashes and colons in absolute (rooted) patterns will cause glob parse errors. This is a well-known issue: nu_glob has some adjustments, but wax does not. The .NET glob (written by Microsoft engineers) doesn't even try to support a rooted pattern.

For now, I'm including a hack for path/pattern arguments on windows only that covers many cases.

// Sanitize a glob pattern for use on windows.
// this allows filesystem commands like `cp` to accept an arg that can be a path or a glob.
// Deal with 3 aspects of windows paths that can confound glob patterns:
// * path separator: change `\` to `/`. Rust file API on windows supports this in folder separators and in UNC paths.
// * drive letter colon: change `C:` to `C\:`
// * quote parens (such as the infamous `Program Files (x86)`).
// But this means user cannot use `\` to quote other metachars.
// (Windows) users of glob should adopt the habit of quoting with single char classes, e.g instead of `\*`, use `[*]`.
// e.g transform something like: `C:\Users\me\.../{abc,def}*.txt` to `C\:/Users/me/.../{abc,def}*.txt`
//todo: investigate enhancing [wax] to support this more elegantly.
pub fn windows_pattern_hack(pat: &str) -> String {
    pat.replace('\\', "/")
        .replace(r#":/"#, r#"\:/"#) // must come after above
        .replace('(', r#"\("#) // when path includes Program Files (x86)
        .replace(')', r#"\)"#)
}

But there will always be paths you might want to copy data from that are unnatural / impossible to quote so they parse as a glob. And telling users that they have to do glob quoting to access a file with [] or {} seems rude.

Maybe we should change arg parsing to check first whether the arg has any glob metachars? But that's expensive (needs a fat regex to cover all the cases). Maybe just stat the argument and assume it's a file if that works or fails in a file-like way?

I'd like to hear how far this hack gets us... Windows users, please give this a try (remember, glob command and ucp only, for now.

due to recent code change!

but metachar left brace is.

bobhy · 2023-10-01T17:29:10Z

@jntrnr On the contrary, I can confirm that {} are legal in both unix and windows filenames.
But we already had that problem -- glob already supported [], and those are also legal in filenames.

But paths with these special characters to cause a problem: if you do have a path with these glob chars and you specify a similar glob. Example:

> touch a[b]c abc abd
> mkdir foo
> ls
╭───┬───────┬──────┬──────┬──────────╮
│ # │ name  │ type │ size │ modified │
├───┼───────┼──────┼──────┼──────────┤
│ 0 │ a[b]c │ file │  0 B │ now      │
│ 1 │ abc   │ file │  0 B │ now      │
│ 2 │ abd   │ file │  0 B │ now      │
│ 3 │ foo   │ dir  │  2 B │ now      │
╰───┴───────┴──────┴──────┴──────────╯
> ucp a[b]c foo
> ls foo
╭───┬─────────┬──────┬──────┬──────────╮
│ # │  name   │ type │ size │ modified │
├───┼─────────┼──────┼──────┼──────────┤
│ 0 │ foo/abc │ file │  0 B │ now      │
╰───┴─────────┴──────┴──────┴──────────╯

User could reasonably complain that the command should have copied file a[b]c.

bobhy · 2023-10-01T17:56:50Z

... Looking into this situation a bit more, it's a bigger problem. Opening #10571 to discuss.

I propose we merge this PR (since it's a step in a direction we (or at least, I) want to go and doesn't make the new issue any worse), then focus on resolving the new issue.

sophiajt · 2023-10-01T19:40:30Z

@jntrnr On the contrary, I can confirm that {} are legal in both unix and windows filenames.

Then let's not go this direction. I'd rather make the built-in glob conservative, and if people want a fancier glob capability, that they would use the glob command.

#10498 is not a bug. (I comment on why in the issue)

…e trying glob.

crates/nu-cmd-base/src/arg_glob.rs

bobhy · 2023-10-02T16:04:20Z

the last checkin fixes the problem of #10571, but reverts to the problem of absolute glob patterns on Windows: e.g c:\users\me/*.txt fails with glob syntax error because both : and \ are glob metacharacters. But I think I can cover that scenario too.
Marking as draft while I work on it...

bobhy · 2023-10-10T06:51:27Z

3rd step done!

add arg_glob() wraps nu_glob::glob_with() where pattern is file system command argument (and might be a path or a pattern) (fixes cp, ls and others cannot access file that is actually present (and accessible). #10571)
convert ucp to use arg_glob() as proof of concept
modify nu_glob to support {} (match existing files only, not for generating non-existing paths)
modify rest of filesystem commands to use arg_glob().

crates/nu-cmd-base/Cargo.toml

bobhy · 2023-10-10T21:46:09Z

Now that I'm down to the bit of the project that brought me here, I'm pretty sure it's a bad idea.
In traditional shells, the {} is not really a glob construct, it's what bash calls "brace expansion", and it operates entirely at the syntax level, doesn't care whether the resulting strings match files or not.
And that's the feature I want!, so that commands like mv a.out{,.old} or diff {../worktrees/main,.}/crates/nu-cmd-base/src/lib.rs can be used. I still think nushell should have this ability, but it's not something that makes sense for a globbing facility to do, and probably should use different metacharacters in deference to nu block {}.
wax does have a {} construct, but it is strictly a pattern matching thing and won't return nonexistant paths (when globbing files), so nu glob will support this more limited ability.

So, bottom line, I'm submitting this PR for review as it now stands, updating the title to match what it actually accomplishes and moving on to other work.

bobhy · 2023-10-10T22:48:36Z

Last note: behavior of ls command is unchanged, because it uses a different globbing function than mv, rm, cp and the rest of the filesystem commands. This might create some user confusion, but I can't wrap my head around it right now.

fdncred · 2023-10-11T18:51:03Z

@bobhy can you update the issue body to explain what exactly this does. there have been quite a few changes and a reverse of direction here. It's difficult to consume this PR as it sits because it's hard to wade through all the subsequent steps you went through to get where you're at here. I'd like to point the core-team here and ask them to make a decision based on what the body/description says and then reviewing the code. Maybe you've already done that. Please let me know.

bobhy · 2023-10-12T08:44:41Z

Squashing the history and reposting as a new clean PR #10694.

…#10694) (squashed version of #10557, clean commit history and review thread) Fixes #10571, also potentially: #10364, #10211, #9558, #9310, # Description Changes processing of arguments to filesystem commands that are source paths or globs. Applies to `cp, cp-old, mv, rm, du` but not `ls` (because it uses a different globbing interface) or `glob` (because it uses a different globbing library). The core of the change is to lookup the argument first as a file and only glob if it is not. That way, a path containing glob metacharacters can be referenced without glob quoting, though it will have to be single quoted to avoid nushell parsing. Before: A file path that looks like a glob is not matched by the glob specified as a (source) argument and takes some thinking about to access. You might say the glob pattern shadows a file with the same spelling. ``` > ls a* ╭───┬────────┬──────┬──────┬────────────────╮ │ # │ name │ type │ size │ modified │ ├───┼────────┼──────┼──────┼────────────────┤ │ 0 │ a[bc]d │ file │ 0 B │ 34 seconds ago │ │ 1 │ abd │ file │ 0 B │ now │ │ 2 │ acd │ file │ 0 B │ now │ ╰───┴────────┴──────┴──────┴────────────────╯ > cp --verbose 'a[bc]d' dest copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd > ## Note -- a[bc]d *not* copied, and seemingly hard to access. > cp --verbose 'a\[bc\]d' dest Error: × No matches found ╭─[entry #33:1:1] 1 │ cp --verbose 'a\[bc\]d' dest · ─────┬──── · ╰── no matches found ╰──── > #.. but is accessible with enough glob quoting. > cp --verbose 'a[[]bc[]]d' dest copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d ``` Before_2: if file has glob metachars but isn't a valid pattern, user gets a confusing error: ``` > touch 'a[b' > cp 'a[b' dest Error: × Pattern syntax error near position 30: invalid range pattern ╭─[entry #13:1:1] 1 │ cp 'a[b' dest · ──┬── · ╰── invalid pattern ╰──── ``` After: Args to cp, mv, etc. are tried first as literal files, and only as globs if not found to be files. ``` > cp --verbose 'a[bc]d' dest copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d > cp --verbose '[a][bc]d' dest copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd ``` After_2: file with glob metachars but invalid pattern just works. (though Windows does not allow file name to contain `*`.). ``` > cp --verbose 'a[b' dest copied /home/bobhy/src/rust/work/r4/a[b to /home/bobhy/src/rust/work/r4/dest/a[b ``` So, with this fix, a file shadows a glob pattern with the same spelling. If you have such a file and really want to use the glob pattern, you will have to glob quote some of the characters in the pattern. I think that's less confusing to the user: if ls shows a file with a weird name, s/he'll still be able to copy, rename or delete it. # User-Facing Changes Could break some existing scripts. If user happened to have a file with a globbish name but was using a glob pattern with the same spelling, the new version will process the file and not expand the glob. # Tests + Formatting  # After Submitting  --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>

…nushell#10694) (squashed version of nushell#10557, clean commit history and review thread) Fixes nushell#10571, also potentially: nushell#10364, nushell#10211, nushell#9558, nushell#9310, # Description Changes processing of arguments to filesystem commands that are source paths or globs. Applies to `cp, cp-old, mv, rm, du` but not `ls` (because it uses a different globbing interface) or `glob` (because it uses a different globbing library). The core of the change is to lookup the argument first as a file and only glob if it is not. That way, a path containing glob metacharacters can be referenced without glob quoting, though it will have to be single quoted to avoid nushell parsing. Before: A file path that looks like a glob is not matched by the glob specified as a (source) argument and takes some thinking about to access. You might say the glob pattern shadows a file with the same spelling. ``` > ls a* ╭───┬────────┬──────┬──────┬────────────────╮ │ # │ name │ type │ size │ modified │ ├───┼────────┼──────┼──────┼────────────────┤ │ 0 │ a[bc]d │ file │ 0 B │ 34 seconds ago │ │ 1 │ abd │ file │ 0 B │ now │ │ 2 │ acd │ file │ 0 B │ now │ ╰───┴────────┴──────┴──────┴────────────────╯ > cp --verbose 'a[bc]d' dest copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd > ## Note -- a[bc]d *not* copied, and seemingly hard to access. > cp --verbose 'a\[bc\]d' dest Error: × No matches found ╭─[entry nushell#33:1:1] 1 │ cp --verbose 'a\[bc\]d' dest · ─────┬──── · ╰── no matches found ╰──── > #.. but is accessible with enough glob quoting. > cp --verbose 'a[[]bc[]]d' dest copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d ``` Before_2: if file has glob metachars but isn't a valid pattern, user gets a confusing error: ``` > touch 'a[b' > cp 'a[b' dest Error: × Pattern syntax error near position 30: invalid range pattern ╭─[entry nushell#13:1:1] 1 │ cp 'a[b' dest · ──┬── · ╰── invalid pattern ╰──── ``` After: Args to cp, mv, etc. are tried first as literal files, and only as globs if not found to be files. ``` > cp --verbose 'a[bc]d' dest copied /home/bobhy/src/rust/work/r4/a[bc]d to /home/bobhy/src/rust/work/r4/dest/a[bc]d > cp --verbose '[a][bc]d' dest copied /home/bobhy/src/rust/work/r4/abd to /home/bobhy/src/rust/work/r4/dest/abd copied /home/bobhy/src/rust/work/r4/acd to /home/bobhy/src/rust/work/r4/dest/acd ``` After_2: file with glob metachars but invalid pattern just works. (though Windows does not allow file name to contain `*`.). ``` > cp --verbose 'a[b' dest copied /home/bobhy/src/rust/work/r4/a[b to /home/bobhy/src/rust/work/r4/dest/a[b ``` So, with this fix, a file shadows a glob pattern with the same spelling. If you have such a file and really want to use the glob pattern, you will have to glob quote some of the characters in the pattern. I think that's less confusing to the user: if ls shows a file with a weird name, s/he'll still be able to copy, rename or delete it. # User-Facing Changes Could break some existing scripts. If user happened to have a file with a globbish name but was using a glob pattern with the same spelling, the new version will process the file and not expand the glob. # Tests + Formatting  # After Submitting  --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>

bobhy added 4 commits September 29, 2023 21:47

arg_glob first draft

8956202

ucp uses arg_glob

a25f368

Merge branch 'main' into wax_glob2

55d9262

clippy refinements

db6d453

bobhy added 2 commits September 30, 2023 14:48

Merge branch 'main' into wax_glob2

67a1d60

Handle rooted pattern on Windows, v0.1

0279da0

fdncred reviewed Sep 30, 2023

View reviewed changes

crates/nu-cmd-base/src/arg_glob.rs Outdated Show resolved Hide resolved

fdncred reviewed Sep 30, 2023

View reviewed changes

crates/nu-cmd-base/src/arg_glob.rs Outdated Show resolved Hide resolved

bobhy added 4 commits September 30, 2023 19:44

Merge branch 'main' into wax_glob2

f9927ee

hack glob pattern on windows only;

bc26c83

esp rooted patterns with device or unc share into legit glob paths.

fix code in windows sections, too.

c9ae20c

Got clipped.

5483129

bobhy added 3 commits September 30, 2023 22:47

harmonize windows and non-windows code.

9cd27fb

Fix prev working test now broken on Windows;

b5ce402

due to recent code change!

Asterisk is not legal in windows paths,

9ced035

but metachar left brace is.

bobhy mentioned this pull request Oct 1, 2023

cp, ls and others cannot access file that is actually present (and accessible). #10571

Closed

bobhy added 3 commits October 1, 2023 18:16

Merge branch 'main' into wax_glob2

58a29d2

revert windows hack; instead check whether arg is existing file befor…

442e539

…e trying glob.

fmt fixes silently made by local toolkit check pr

cfdec92

fdncred reviewed Oct 2, 2023

View reviewed changes

crates/nu-cmd-base/src/arg_glob.rs Outdated Show resolved Hide resolved

bobhy marked this pull request as draft October 2, 2023 16:04

Fix test broken by change from generic error to specific fileNotFound

f77bc1f

clippo

0dbbc18

bobhy force-pushed the wax_glob2 branch from 66c695c to 0dbbc18 Compare October 10, 2023 06:56

fdncred reviewed Oct 10, 2023

View reviewed changes

crates/nu-cmd-base/Cargo.toml Outdated Show resolved Hide resolved

fix CI failure -- can't stat file with '*' on Windows

94069b0

bobhy mentioned this pull request Oct 10, 2023

Using Glob Patterns in File Operations and Dealing with No Match Found Error #10673

Closed

clippo

36b7d7e

atahabaki mentioned this pull request Oct 10, 2023

What if the file exists with glob pattern #10677

Closed

removed unused dependency, fix Cargo.lock

1fef926

bobhy changed the title ~~Enable {} glob metachars in command arguments~~ Allow filesystem commands to access files with glob metachars in name Oct 10, 2023

bobhy marked this pull request as ready for review October 10, 2023 22:48

bobhy mentioned this pull request Oct 12, 2023

Allow filesystem commands to access files with glob metachars in name #10694

Merged

bobhy closed this Oct 12, 2023

bobhy deleted the wax_glob2 branch October 13, 2023 15:37

Conversation

bobhy commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Original title: Enable {} glob metachars in command arguments

Description

User-Facing Changes

Tests + Formatting

After Submitting

Uh oh!

fdncred commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobhy commented Sep 30, 2023

Uh oh!

Uh oh!

fdncred Sep 30, 2023

Choose a reason for hiding this comment

Uh oh!

bobhy Oct 1, 2023

Choose a reason for hiding this comment

Uh oh!

fdncred Oct 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sophiajt commented Oct 1, 2023

Uh oh!

bobhy commented Oct 1, 2023 • edited by fdncred Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobhy commented Oct 1, 2023

Uh oh!

bobhy commented Oct 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sophiajt commented Oct 1, 2023

Uh oh!

Uh oh!

bobhy commented Oct 2, 2023

Uh oh!

bobhy commented Oct 10, 2023

Uh oh!

Uh oh!

bobhy commented Oct 10, 2023

Uh oh!

bobhy commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdncred commented Oct 11, 2023

Uh oh!

bobhy commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bobhy commented Sep 30, 2023 •

edited

Loading

fdncred commented Sep 30, 2023 •

edited

Loading

bobhy commented Oct 1, 2023 •

edited by fdncred

Loading

bobhy commented Oct 1, 2023 •

edited

Loading

bobhy commented Oct 10, 2023 •

edited

Loading