make better error message for not operator#10507
Merged
sholderbach merged 1 commit intonushell:mainfrom Sep 26, 2023
Merged
Conversation
sholderbach
approved these changes
Sep 26, 2023
Member
sholderbach
left a comment
There was a problem hiding this comment.
Thanks!
Reminds me that we should get to polishing the ShellError and ParseError variants. Pretty useless TypeMismatch out of the box.
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
Fixes: nushell#10476 After the change, the error message will be something like this: ```nushell ❯ not null Error: nu::shell::type_mismatch × Type mismatch. ╭─[entry nushell#11:1:1] 1 │ not null · ──┬─ · ╰── expected bool, found nothing ╰──── ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10476
After the change, the error message will be something like this: