fix public boolean switches in the standard library#10477
Merged
fdncred merged 1 commit intonushell:mainfrom Sep 23, 2023
Merged
fix public boolean switches in the standard library#10477fdncred merged 1 commit intonushell:mainfrom
fdncred merged 1 commit intonushell:mainfrom
Conversation
Contributor
|
Thanks |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
related to - nushell#10456 # Description this PR will fix the public API of the standard library by removing the type annotations from public boolean switches. 1. the signature before ```nushell clip [--silent: bool, --no-notify: bool, --no-strip: bool, --expand (-e): bool, --codepage (-c): int] ``` 2. the signature after ```nushell clip [--silent, --no-notify, --no-strip, --expand (-e), --codepage (-c): int] ``` # User-Facing Changes ### before ```nushell > "foo" | clip Error: nu::shell::cant_convert × Can't convert to bool. ╭─[NU_STDLIB_VIRTUAL_DIR/std/mod.nu:148:1] 148 │ $in 149 │ | if $expand { table --expand } else { table } · ───┬─── · ╰── can't convert nothing to bool 150 │ | into string ╰──── ``` ### after ```nushell > "foo" | clip foo saved to clipboard ``` # Tests + Formatting # After Submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to
--xand--x: bool#10456Description
this PR will fix the public API of the standard library by removing the type annotations from public boolean switches.
User-Facing Changes
before
after
Tests + Formatting
After Submitting