Skip to content

Revert "Add git coommit completions"#868

Merged
fdncred merged 1 commit intomainfrom
revert-854-git-commit
Jun 5, 2024
Merged

Revert "Add git coommit completions"#868
fdncred merged 1 commit intomainfrom
revert-854-git-commit

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Jun 5, 2024

Reverts #854

This PR broke the git aliases https://github.com/nushell/nu_scripts/blob/main/aliases/git/git-aliases.nu so I'm reverting it.

@fdncred fdncred merged commit 5adf14d into main Jun 5, 2024
@fdncred fdncred deleted the revert-854-git-commit branch June 5, 2024 12:21
fdncred added a commit that referenced this pull request Jun 5, 2024
fdncred added a commit that referenced this pull request Jun 5, 2024
Reverts #868

I found that this works, if you source these files like
```
use aliases/git/git-aliases.nu *
use custom-completions/git/git-completions.nu *
```
but if you source them like this, it doesn't work.
```
use custom-completions/git/git-completions.nu *
use aliases/git/git-aliases.nu *
```

This changed recently somewhere in nushell.
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 12, 2024
Reverts nushell/nu_scripts#868

I found that this works, if you source these files like
```
use aliases/git/git-aliases.nu *
use custom-completions/git/git-completions.nu *
```
but if you source them like this, it doesn't work.
```
use custom-completions/git/git-completions.nu *
use aliases/git/git-aliases.nu *
```

This changed recently somewhere in nushell.
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 13, 2024
Reverts nushell/nu_scripts#868

I found that this works, if you source these files like
```
use aliases/git/git-aliases.nu *
use custom-completions/git/git-completions.nu *
```
but if you source them like this, it doesn't work.
```
use custom-completions/git/git-completions.nu *
use aliases/git/git-aliases.nu *
```

This changed recently somewhere in nushell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant