You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Backport tests from #4692
To verify the functionality from 3.x that we're restoring. Relates to #4598
This PR also switches the macos image on github actions to target specifically macos-12 in order to work around this NET5-related issue: dotnet/runtime#48068. It seems this may be the first time we're running CI on the 3.x branch since macos-latest was changed to macos-14 and the newer silicon architecture.
@nunit/framework-team
I've noticed net5 tests still running on the 3.x branch are now failing on macos. That runtime has been EOL for a while and is no longer used in main. Any objections to me removing it from 3.x either within this PR or separately?
I believe we have stated that 3.X will continue to support these OOD frameworks.
Can't we just disable that test from MacOS, and make a note of it ?
I believe we do have some more of those, which have been marked the same way, I think using the Platform attribute.
Huh interesting. Thanks for having me take a closer look here @OsirisTerje
I had thought it was a NET5 EOL issue but the real thing here was that macos-latest switched to macos-14 which uses newer Apple Silicon / M1+. It appears this was a known issue a few years back with NET5 not working there in all cases: dotnet/runtime#48068
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport tests from #4692
To verify the functionality from 3.x that we're restoring. Relates to #4598
This PR also switches the macos image on github actions to target specifically
macos-12in order to work around this NET5-related issue: dotnet/runtime#48068. It seems this may be the first time we're running CI on the 3.x branch sincemacos-latestwas changed tomacos-14and the newer silicon architecture.