Avoid masks when possible in AVX2 logic#104
Merged
r-devulap merged 1 commit intonumpy:mainfrom Nov 21, 2023
Merged
Conversation
Member
|
Initially I expected this be wrong because you would be writing incorrect data to the array with the unmasked stores. But then I realized they get overwritten by the right numbers in subsequent stores. You don't need the masked store at all any point of time (even for the last register).
Never mind, that was surprisingly horrible! |
r-devulap
reviewed
Nov 20, 2023
src/avx2-emu-funcs.hpp
Outdated
|
|
||
| vtype::mask_storeu(leftStore, left, temp); | ||
| vtype::mask_storeu(rightStore, _mm256_xor_si256(oxff, left), temp); | ||
| if constexpr (masked) { |
Member
There was a problem hiding this comment.
Do we need the masked store? I think we can get away with just the regular store. Or am I wrong?
58ab67d to
23b6d32
Compare
r-devulap
pushed a commit
to r-devulap/numpy
that referenced
this pull request
Nov 27, 2023
Perf improvements to AVX2 sorting: see numpy/x86-simd-sort#104
r-devulap
pushed a commit
to r-devulap/numpy
that referenced
this pull request
Nov 30, 2023
Perf improvements to AVX2 sorting: see numpy/x86-simd-sort#104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids using masked stores when unmasked stores can be used. This gives a reasonable performance improvement for AVX2 quicksort.