Skip to content

🏷️ stub numpy.random._pickle#276

Merged
jorenham merged 2 commits intonumpy:mainfrom
guan404ming:stub-numpy.random._pickle
Mar 7, 2025
Merged

🏷️ stub numpy.random._pickle#276
jorenham merged 2 commits intonumpy:mainfrom
guan404ming:stub-numpy.random._pickle

Conversation

@guan404ming
Copy link
Copy Markdown
Member

@guan404ming guan404ming commented Mar 7, 2025

close #63

@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from 5f1bcd7 to 98141a8 Compare March 7, 2025 16:31
jorenham

This comment was marked as outdated.

Sign in to view

@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from a713d69 to 4b6195b Compare March 7, 2025 16:57
@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from 4b6195b to 4c8b650 Compare March 7, 2025 16:59
@guan404ming
Copy link
Copy Markdown
Member Author

guan404ming commented Mar 7, 2025

@jorenham updated please help me review, thanks~

jorenham
jorenham reviewed Mar 7, 2025
View reviewed changes
@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from 65b8780 to 72e8607 Compare March 7, 2025 17:28
@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from 72e8607 to b2b29d1 Compare March 7, 2025 17:31
@guan404ming
Copy link
Copy Markdown
Member Author

guan404ming commented Mar 7, 2025 •
edited
Loading

Should I open a PR in numpy when this one is merged?

jorenham
jorenham reviewed Mar 7, 2025
View reviewed changes
@jorenham
Copy link
Copy Markdown
Member

jorenham commented Mar 7, 2025

Should I open a PR in numpy when this one is merged?

Yea sure, that'd help

@guan404ming guan404ming force-pushed the stub-numpy.random._pickle branch from 06f19eb to b2b29d1 Compare March 7, 2025 17:37
@jorenham jorenham added stubs: Incomplete numpy.random.* port: to numpy NumType PR's that should be ported to NumPy labels Mar 7, 2025
@jorenham jorenham added this to the v2.2.x.0 milestone Mar 7, 2025
@jorenham
Copy link
Copy Markdown
Member

jorenham commented Mar 7, 2025

good to merge?

@guan404ming
Copy link
Copy Markdown
Member Author

guan404ming commented Mar 7, 2025

sure~

@jorenham jorenham merged commit 344a4c5 into numpy:main Mar 7, 2025
26 checks passed
@jorenham
Copy link
Copy Markdown
Member

jorenham commented Mar 7, 2025

Thanks again, Guan :)

@jorenham
Copy link
Copy Markdown
Member

jorenham commented Mar 7, 2025

Thanks again, Guan :)

Or do you prefer Guan-Ming 🤔 ?

@guan404ming
Copy link
Copy Markdown
Member Author

guan404ming commented Mar 7, 2025

I prefer Guan-Ming! haha thx

@jorenham
Copy link
Copy Markdown
Member

jorenham commented Mar 7, 2025

I prefer Guan-Ming! haha thx

Good I asked then; I'll keep that in mind :)

@guan404ming
Copy link
Copy Markdown
Member Author

guan404ming commented Mar 7, 2025

Glad you asked, appreciate it! 😊

@guan404ming guan404ming mentioned this pull request Mar 8, 2025
Merged
@jorenham jorenham removed the port: to numpy NumType PR's that should be ported to NumPy label Mar 14, 2025
@guan404ming guan404ming deleted the stub-numpy.random._pickle branch March 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

numpy.random.* stubs: Incomplete

Projects

None yet

Milestone

v2.4.x.0a1

Development

Successfully merging this pull request may close these issues.

Stubs missing for numpy.random._pickle

2 participants

@guan404ming @jorenham