Skip to content

TST: Backport #7116 and #7171#7172

Merged
charris merged 2 commits intonumpy:maintenance/1.11.xfrom
gfyoung:backport-7116-and-7171
Feb 2, 2016
Merged

TST: Backport #7116 and #7171#7172
charris merged 2 commits intonumpy:maintenance/1.11.xfrom
gfyoung:backport-7116-and-7171

Conversation

@gfyoung
Copy link
Copy Markdown
Contributor

@gfyoung gfyoung commented Feb 2, 2016

Backport test_f2py fixes from #7116 and #7171.

@charris charris added this to the 1.11.0 release milestone Feb 2, 2016
@charris charris added 08 - Backport Used to tag backport PRs 05 - Testing labels Feb 2, 2016
@gfyoung gfyoung changed the title BUG: Backport #7116 and #7171 TST: Backport #7116 and #7171 Feb 2, 2016
@gfyoung
Copy link
Copy Markdown
Contributor Author

gfyoung commented Feb 2, 2016

Could anyone by any chance cancel my first two builds on Appveyor for this PR as well as my second build on Travis? They are all out of date builds now and would certainly speed things up on Appveyor. I would do it myself, but I have no permission on either site.

@gfyoung
Copy link
Copy Markdown
Contributor Author

gfyoung commented Feb 2, 2016

Alas, I forgot about backwards compatibility with Python 2.6. To whoever cancelled my Appveyor builds (BTW: thanks!), if you could also cancel the remaining builds for my PR, that would be great!

charris added a commit that referenced this pull request Feb 2, 2016
@charris charris merged commit 409b267 into numpy:maintenance/1.11.x Feb 2, 2016
@charris
Copy link
Copy Markdown
Member

charris commented Feb 2, 2016

Thanks @gfyoung .

@gfyoung gfyoung deleted the backport-7116-and-7171 branch February 2, 2016 22:55
@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Feb 14, 2016

If your appveyor queue time for outdated builds is a frequent problem, you can have this snippet (MIT licensed from Julia):

# If there's a newer build queued for the same PR, cancel this one
  - ps: if ($env:APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER -ne ((Invoke-RestMethod `
        https://ci.appveyor.com/api/projects/$env:APPVEYOR_ACCOUNT_NAME/$env:APPVEYOR_PROJECT_SLUG/history?recordsNumber=50).builds | `
        Where-Object pullRequestId -eq $env:APPVEYOR_PULL_REQUEST_NUMBER)[0].buildNumber) { `
        throw "There are newer queued builds for this pull request, failing early." }

edit: and equivalent for Travis https://github.com/JuliaLang/julia/blob/master/contrib/travis_fastfail.sh

@gfyoung
Copy link
Copy Markdown
Contributor Author

gfyoung commented Feb 14, 2016

@tkelman : Could you put up a PR for that? I think lots of people would be happy with such an addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 - Testing 08 - Backport Used to tag backport PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants