ENH: Add subok parameter to np.copy function#6509
Closed
jjhelmus wants to merge 1 commit intonumpy:masterfrom
Closed
ENH: Add subok parameter to np.copy function#6509jjhelmus wants to merge 1 commit intonumpy:masterfrom
jjhelmus wants to merge 1 commit intonumpy:masterfrom
Conversation
The subok parameter determines if sub-classes are passed through.
Member
|
Sounds reasonable to me (i.e. not much extra clutter ;)) so +0.5 from me. Would need a |
eric-wieser
requested changes
Feb 20, 2017
| assert np.ma.isMaskedArray(np.copy(mx, subok=True)) | ||
| assert not np.ma.isMaskedArray(np.copy(mx, subok=False)) | ||
| # default is to force base class | ||
| assert not np.ma.isMaskedArray(np.copy(mx)) |
Member
There was a problem hiding this comment.
Should be using the assert_ function
|
@jjhelmus are you proceeding with this? |
Contributor
Author
This PR has lingered for too long that I do not recall why the changes were needed. I'm closing as I do not have the time to reexamine this. |
rossbar
added a commit
to rossbar/numpy
that referenced
this pull request
Mar 2, 2020
Re-introduces changes originally proposed in numpy#6509 which was closed due to very long review period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subok parameter determines if sub-classes are passed through. Setting the argument to True will cause sub-classes, such as MaskedArrays, to be returned after copying. The default, False, force the copy to be of the base-class, to maintain backwards compatibility.