PEP8 and pyflakes fixups for numpy/core/tests/*.py#6047
Merged
charris merged 4 commits intonumpy:masterfrom Jul 25, 2015
Merged
PEP8 and pyflakes fixups for numpy/core/tests/*.py#6047charris merged 4 commits intonumpy:masterfrom
charris merged 4 commits intonumpy:masterfrom
Conversation
8a3d5a3 to
baa63b4
Compare
Member
Author
|
This one is ready. |
The fixes do not include the pretty formatting of array data. Lond lines are also left intact at this point.
There were two classes named TestArrayPriority in test_multiarray.py, both of which tested the use of the __array_priority__ attribute. Because the later addition tests more functions than the earlier one and for more dtypes, the earlier version is removed.
Many of these fixups are result from removing `from x import *` imports. The rest are mostly unused variable fixes.
The dot tests in test_numeric have not done anything useful since the _dotblas module was merged into multiarray. There used to be two potentially different dot functions, one from _dotblas and the other from multiarray, that the tests compared against each other. Because both functions are now the same that no longer serves any purpose, so those tests have been modified to check against known results and moved into test_multiarray with the other dot tests. The dot tests could use improvement. They don't check all the types, exceptions, and such. But fixing them exceeds the scope of the present work.
baa63b4 to
730adaa
Compare
charris
added a commit
that referenced
this pull request
Jul 25, 2015
PEP8 and pyflakes fixups for numpy/core/tests/*.py
Member
Author
|
Merging this for the 1.10 release. |
This was referenced Jul 25, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes do not include the pretty formatting of array data. Long
lines are also left intact at this point.
This one is still a WIP, needs application of pyflakes.
EDIT: OK, this one should be done.