1.10 deprecated removal#5990
Merged
charris merged 9 commits intonumpy:masterfrom Jun 21, 2015
Merged
Conversation
Member
Author
|
The first commit may break older versions of SciPy, although Scipy currently does not use the Numpy version anywhere. |
0301562 to
6318c68
Compare
Member
Author
|
That's all folks. |
Member
There was a problem hiding this comment.
Not your job, but just noticed that there is a copy paste error here, The message should ask to use ~ I think.
16c3502 to
20860e6
Compare
These functions npy_PyFile_Dup and npy_PyFile_DupClose do not work correctly in Python 3. Deprecation messages have been raised in npy_PyFile_Dup since 1.9 and it is probably best to smoke out any remaining uses by simply removing the function.
This was deprecated in NumPy 1.7 with a warning that it would raise an error in the future. Tests for the new error are added and the test that allowed that special case is removed.
This is to make it easier to find and remove deprecated features. It would be a good idea if all deprecations were made with similar comments.
20860e6 to
2205136
Compare
Member
Author
|
OK, fixed the quibbles and removed the last two risky deprecation removals for a separate PR. |
Was in numpy/distutils/exec_command.py. Update 1.10-notes.rst.
Deprecated functions in numpy/distutils/command/config.py.
Deprecated, removed from numpy/core/arrayprint.py.
Some keywords are deprecated and slated for removal in numpy 2.0. Add comment to deprecation date to clarify that.
2205136 to
a27f560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some deprecated bits and mark all Deprecations with a date and Numpy version for further action.
This PR is not finished yet, but need review anyway ;)
One question is what to do with deprecated C-API functions, of which there are four. We can't remove them, but perhaps we should return an error. Thoughts?