Expanded warning conditions for array_split#5771
Closed
MichaelCurrie wants to merge 1 commit intonumpy:masterfrom
MichaelCurrie:master
Closed
Expanded warning conditions for array_split#5771MichaelCurrie wants to merge 1 commit intonumpy:masterfrom MichaelCurrie:master
MichaelCurrie wants to merge 1 commit intonumpy:masterfrom
MichaelCurrie:master
Conversation
Zero arrays can also occur with any of the partitions sub_arys[i] induced by array_split, not just the final partition sub_arys[-1].
Member
|
Oh, right, when indices are passed in, I guess. Can you maybe make a test as well? That could be usefull also to convert the test in the future. Could keep the Anyway, looks good to me, mostly would like the extra test. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Sep 27, 2015
Zero arrays can also occur with any of the partitions sub_arys[i] induced by array_split, not just the final partition sub_arys[-1]. Modified by seberg. Closes numpygh-5771
Contributor
|
☔ The latest upstream changes (presumably #6371) made this pull request unmergeable. Please resolve the merge conflicts. |
jaimefrio
pushed a commit
to jaimefrio/numpy
that referenced
this pull request
Mar 22, 2016
Zero arrays can also occur with any of the partitions sub_arys[i] induced by array_split, not just the final partition sub_arys[-1]. Modified by seberg. Closes numpygh-5771
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-sized arrays can also occur with any of the partitions sub_arys[i]
induced by array_split, not just the final partition sub_arys[-1].