Revert line from #4585 to get mask, data shapes to match in .flat#4615
Merged
charris merged 1 commit intonumpy:masterfrom Apr 12, 2014
Merged
Revert line from #4585 to get mask, data shapes to match in .flat#4615charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
numpy/ma/tests/test_core.py
Outdated
Member
There was a problem hiding this comment.
Should not use docstrings in tests, use comments #... instead. It makes the nose output more readable.
Member
There was a problem hiding this comment.
Note that we haven't yet fixed all tests for this, especially the corroded antiquities. Software years are so very short...
Contributor
Author
|
@charris -- ok, changed docstring to comment (these are astropy habits coming through -- there, the request is the opposite). I do still hope to get to changing |
Member
|
Fast. LGTM pending travis. |
charris
added a commit
that referenced
this pull request
Apr 12, 2014
Revert line from #4585 to get mask, data shapes to match in .flat
Member
|
Merged, thanks Marten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@charris -- this reverts the shape assignment and adds a test for the problematic matrix masked array example that you gave in #4585. Now, as expected: