BUG Masked arrays treated incorrectly in isclose(..,..,equal_nan=True)#3914
Merged
charris merged 1 commit intonumpy:masterfrom Oct 16, 2013
Merged
BUG Masked arrays treated incorrectly in isclose(..,..,equal_nan=True)#3914charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
Member
|
LGTM, thanks. |
charris
added a commit
that referenced
this pull request
Oct 16, 2013
BUG Masked arrays treated incorrectly in isclose(..,..,equal_nan=True)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the mask of a MaskedArray is incorrectly changed in the following:
yields
The problem lies in the fact that in
isclose, the following final assignment is doneThe problem here is that the mask of the index is ignored in
__setitem__(and it would be very hard to do otherwise), but and hence all elements are being set. SinceTruehas no mask, the mask of all ements is cleared. To avoid this, this PR ensured that the vallues used include a mask, by replacing the above line withA test case is included as well.
p.s. This bug was found while trying to allow
MaskedArrayto behave better with subclasses; see #3907