BUG: Fix busdaycalendar's handling of a bool array weekmask.#30885
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Feb 27, 2026
Merged
BUG: Fix busdaycalendar's handling of a bool array weekmask.#30885ngoldbaum merged 1 commit intonumpy:mainfrom
ngoldbaum merged 1 commit intonumpy:mainfrom
Conversation
seberg
approved these changes
Feb 26, 2026
Member
seberg
left a comment
There was a problem hiding this comment.
Thanks Warren! I can't of a nice way to allow this but remove teh caveat so the caveat seems OK to me.
(Converting to a NumPy bool might work, but doesn't reall seem worth it here. Doesn't mean I have any confidence that this functionality should be used, hehe ;).)
(It's a tricky world, with our bools not being integer subclasses, unlike Python bools.)
Member
|
Thanks @WarrenWeckesser! |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Mar 4, 2026
charris
added a commit
that referenced
this pull request
Mar 4, 2026
BUG: Fix busdaycalendar's handling of a bool array weekmask. (#30885)
sabasiddique1
pushed a commit
to sabasiddique1/numpy
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-30883.
This change is simple but it has implications beyond the problem observed in gh-30883. With this change, when
weekmaskis a sequence, the boolean array is created by evaluating the "truthiness" of the elements in the sequence. This might be more flexible than desired.For example, with this PR, we have the following behavior:
Before this change, that sequence of strings would result in a
TypeError: