BUG: fix free-threaded PyObject layout in replace_scalar_type_names helper#30686
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Jan 20, 2026
Merged
BUG: fix free-threaded PyObject layout in replace_scalar_type_names helper#30686ngoldbaum merged 1 commit intonumpy:mainfrom
ngoldbaum merged 1 commit intonumpy:mainfrom
Conversation
[skip actions] [skip azp] [skip cirrus]
ngoldbaum
commented
Jan 20, 2026
| # an anonymous struct that we don't try to model | ||
| ('__private', ctypes.c_int64), | ||
| ('ob_type', ctypes.POINTER(PyTypeObject)), | ||
| ] |
Member
Author
There was a problem hiding this comment.
seberg
approved these changes
Jan 20, 2026
Member
seberg
left a comment
There was a problem hiding this comment.
Jeesh, this is terrible, I wonder if we should just have a private helper in C to do this, seems almost saner...
(At least using PyObject_Type() for the first step...)
Anyway, LGTM, maybe ugly, but it'll keep working for many years probably so...
Member
Author
|
Merging since the docs build passed. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 21, 2026
charris
added a commit
that referenced
this pull request
Jan 21, 2026
BUG: fix free-threaded PyObject layout in replace_scalar_type_names helper (#30686)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30681.
This function models the layout of PyObject and pokes at it via ctypes. It was poking at bits outside of
tp_nameon the free-threaded build. The fix is to model PyObject correctly on free-threading.The layout of PyObject is different on 3.13t but the size is the same so this should still work there. I tested on 3.14.2t.